Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from snafu for pub interfaces #32

Open
cbgbt opened this issue Dec 11, 2023 · 1 comment
Open

Move away from snafu for pub interfaces #32

cbgbt opened this issue Dec 11, 2023 · 1 comment
Labels
enhancement New feature or request rust Pull requests that update Rust code

Comments

@cbgbt
Copy link
Contributor

cbgbt commented Dec 11, 2023

Per a comment from @webern on #31:

We are exposing a library and its traits in our public interface and it might be impossible to avoid a major version break if the Snafu library changes in some way.

We may wish to more closely control the fate of our public API by using our own error types, either across the board or by converting to them at the last moment for any pub methods. The downside to the "JIT"-style conversions is that it's not easy to create a mechanism to check this for us at compile-time.

@cbgbt cbgbt added enhancement New feature or request rust Pull requests that update Rust code labels Dec 11, 2023
@webern
Copy link
Contributor

webern commented Dec 11, 2023

Consider, for example, that a user may be completely broken by two major versions of the Context trait (if they are also using Snafu for their own error types).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rust Pull requests that update Rust code
Projects
None yet
Development

No branches or pull requests

2 participants