Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to change settings with apiclient #1238

Closed
tjkirch opened this issue Dec 11, 2020 · 1 comment · Fixed by #1278
Closed

Make it easier to change settings with apiclient #1238

tjkirch opened this issue Dec 11, 2020 · 1 comment · Fixed by #1278
Assignees
Labels
type/enhancement New feature or request

Comments

@tjkirch
Copy link
Contributor

tjkirch commented Dec 11, 2020

#1219 added some helper methods to apiclient to make it easier to update the system by abstracting away the specific API calls needed. It's also common to change settings using apiclient, and there's a similar overhead - you have to know the URI, the HTTP method, the JSON schema, and then commit and apply a transaction with a second call. We should simplify this common workflow.

@tjkirch tjkirch added type/enhancement New feature or request priority/p1 labels Dec 11, 2020
@tjkirch tjkirch self-assigned this Dec 11, 2020
@tjkirch
Copy link
Contributor Author

tjkirch commented Dec 11, 2020

I'm working on an apiclient set mode that takes simple key=value pairs and handles the transaction for you. It will also have a --json mode for handling repetitive settings deep in the tree, or more complex cases like keys with dots in the name, as sometimes used by k8s node labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant