Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic twoliter make command #13

Closed
1 task done
Tracked by #14
webern opened this issue Jun 5, 2023 · 0 comments · Fixed by #29
Closed
1 task done
Tracked by #14

basic twoliter make command #13

webern opened this issue Jun 5, 2023 · 0 comments · Fixed by #29

Comments

@webern
Copy link
Member

webern commented Jun 5, 2023

Description

Create a subcommand in Twoliter named make which passes through arguments to cargo make.
This will be used to execute Makefile.toml targets during the Bottlerocket monorepo transition to Twoliter.

For example, if a user wants to run cargo make -e FOO=bar variant, then the following command will run (as an alias in the Bottlerocket monorepo):

twoliter make -e FOO=bar variant

The arguments can be taken exactly as the come and be passed directly to cargo make.

Definition of Done

When twoliter make spins up its bootstraping container, and executes cargo make inside it with the same arguments it received.

It is not important for this issue that proper directories be mounted, and the cargo make target will certainly fail. This is fine.

Depends on:

id: texec_command
epic: twoliter_exec

Related to bottlerocket-os/bottlerocket#2669

@webern webern mentioned this issue Aug 11, 2023
3 tasks
@webern webern changed the title basic twoliter exec command basic twoliter make command Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant