Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

echo statements with PATH list variables gain spaces #9

Closed
kevingriffin opened this issue Jan 21, 2021 · 1 comment · Fixed by #10
Closed

echo statements with PATH list variables gain spaces #9

kevingriffin opened this issue Jan 21, 2021 · 1 comment · Fixed by #10

Comments

@kevingriffin
Copy link

Found while testing NixOS/nixpkgs#108947

When echo statements of PATH variables are converted, they don't come back in tact: fish will echo a PATH with colons in it with spaces instead. If this value is saved somewhere, the colons will become spaces, which wouldn't occur in the original bash.

@bouk
Copy link
Owner

bouk commented Jan 21, 2021

Solution: #10

I probably need to quote everything all the time, because if a variable is an array you'll get unexpected results (i.e. cartesian products)

@bouk bouk closed this as completed in #10 Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants