Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPL seems rotated by 180° #2

Closed
Bouni opened this issue Aug 10, 2021 · 3 comments
Closed

CPL seems rotated by 180° #2

Bouni opened this issue Aug 10, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Bouni
Copy link
Owner

Bouni commented Aug 10, 2021

I ordered a board with all the files generated by this plugin, everything looked good in the preview.
As the board went into shipping, I've seen that there's a "DFM analysis" Link in the orders menu that shows what was sent and what and how the engeneers at JLC fixed the CPL files:

image

From the two images it seems that the entire CPL file is rotated by 180 degrees.

Not sure why thats the case ...

@Bouni Bouni added the bug Something isn't working label Aug 10, 2021
@Bouni Bouni self-assigned this Aug 10, 2021
@Bouni
Copy link
Owner Author

Bouni commented Aug 10, 2021

If I generate the CPL/POS file out of Kicad using File -> Fabrication Output -> Component placement I see that all Y coordinates are negative (left side)

image

Maybe I just have to add a * -1 to the Y-coordinate generation at fabrication.py:131

@Bouni
Copy link
Owner Author

Bouni commented Aug 10, 2021

Adding the * -1 fixed the rotation. But I'm not sure if that will fix the Orientation for JLC 🤷🏽

image

@Bouni
Copy link
Owner Author

Bouni commented Aug 11, 2021

I consider this fixed, JLC's preview shows exactly what I expect:

image

@Bouni Bouni closed this as completed Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant