Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Test for Location API #163

Closed
1 task done
elifkizilky opened this issue May 8, 2023 · 2 comments · Fixed by #210
Closed
1 task done

Unit Test for Location API #163

elifkizilky opened this issue May 8, 2023 · 2 comments · Fixed by #210
Assignees
@elifkizilky
Labels
effort : moderate This issue can take some time priority : high Job needs to be completed at most two days status : completed Issue is completed type : development Updates and enhancements on the application

Comments

@elifkizilky
Copy link
Contributor

elifkizilky commented May 8, 2023 •
edited

Issue Description

As for my API which is described at #158, I will create a unit test to make sure that the endpoints working as expected. For this purpose, I will use JEST which my teammate made the configuration earlier.

Tasks

Parts of the task:

  • Create location.test file at tests folder

Extra Comments

No response

Final Step

After I finish my task, I will create a pull request for review.

Deadline of the Issue

09.05.2023 23.59

Reviewer

@yunusemrealtug

Deadline for the Review

10.05.2023 23:59
@elifkizilky elifkizilky added type : development Updates and enhancements on the application priority : high Job needs to be completed at most two days status : new New issue in initial state effort : moderate This issue can take some time labels May 8, 2023
@elifkizilky elifkizilky self-assigned this May 8, 2023
@elifkizilky elifkizilky changed the title Unit Test for API Unit Test for Location API May 8, 2023
@elifkizilky elifkizilky mentioned this issue May 12, 2023
Merged
@elifkizilky elifkizilky linked a pull request May 12, 2023 that will close this issue
Practice app/feature/location history #210
Merged
@elifkizilky elifkizilky added status : need_review This issue is needed to review and removed status : new New issue in initial state labels May 12, 2023
@elifkizilky
Copy link
Contributor Author

The task is implemented and pull request is done. Issue needs review

@yunusemrealtug
Copy link
Contributor

The tests sufficient for the api. Closing.

@yunusemrealtug yunusemrealtug added status : completed Issue is completed and removed status : need_review This issue is needed to review labels May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elifkizilky elifkizilky

Labels
effort : moderate This issue can take some time priority : high Job needs to be completed at most two days status : completed Issue is completed type : development Updates and enhancements on the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Practice app/feature/location history bounswe/bounswe2023group7
2 participants
@elifkizilky @yunusemrealtug