Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Workspace Tag PUT API will be implemented #666

Closed
3 tasks done
Simurgan opened this issue Dec 19, 2023 · 1 comment · Fixed by #673
Closed
3 tasks done

Remove Workspace Tag PUT API will be implemented #666

Simurgan opened this issue Dec 19, 2023 · 1 comment · Fixed by #673
Assignees
@Simurgan
Labels
backend issues related to backend difficulty: moderate Requires more than basic skills and knowledge, and may require research or collaboration to complete priority: critical This issue requires immediate attention to prevent major issues or disruptions. size: medium Requires moderate effort and may take several days to a week to complete. type: implementation This issue is related to implementation
Milestone
CMPE451 Final Mil...

Comments

@Simurgan
Copy link
Contributor

Simurgan commented Dec 19, 2023 •
edited

Issue Description

An API for semantic tag deletion will be implemented.
Also it will support removing it directly from its workspace while being deleted.
I think deletion should be prevented if the semantic tag was assigned to a node.
It will be discussed with the rest of the team

Steps

  • Implementation
  • Tests
  • Documentation

Deadline for the Issue

26.12.2023

P.S updates about this issue can be found below
@Simurgan Simurgan added priority: critical This issue requires immediate attention to prevent major issues or disruptions. size: medium Requires moderate effort and may take several days to a week to complete. difficulty: moderate Requires more than basic skills and knowledge, and may require research or collaboration to complete type: implementation This issue is related to implementation backend issues related to backend labels Dec 19, 2023
@Simurgan Simurgan self-assigned this Dec 19, 2023
@Simurgan Simurgan mentioned this issue Dec 23, 2023
Merged
@Simurgan Simurgan linked a pull request Dec 23, 2023 that will close this issue
Semantic tag post api and remove workspace tag put api #673
Merged
@Simurgan Simurgan changed the title Semantic Tag DELETE API will be implemented Remove Workspace Tag PUT API will be implemented Dec 23, 2023
@Simurgan
Copy link
Contributor Author

This API was initially planned as a DELETE API for semantic tags.
However, since the same semantic tags can be used in different workspaces / profiles, this would be cause some bugs.
For this reason, I decided to implement the API as a PUT API for workspace.
The API removes the specified semantic tag from the specified workspace if the user is eligible to perform this action.
The documentation was added to the postman workspace.

I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Simurgan Simurgan

Labels
backend issues related to backend difficulty: moderate Requires more than basic skills and knowledge, and may require research or collaboration to complete priority: critical This issue requires immediate attention to prevent major issues or disruptions. size: medium Requires moderate effort and may take several days to a week to complete. type: implementation This issue is related to implementation
Projects
None yet
Milestone
CMPE451 Final Milestone: Presentation...
Development

Successfully merging a pull request may close this issue.

Semantic tag post api and remove workspace tag put api bounswe/bounswe2023group9
1 participant
@Simurgan