Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class diagram #106

Closed
1 task done
SouthAscend opened this issue Apr 4, 2024 · 9 comments
Closed
1 task done

Class diagram #106

SouthAscend opened this issue Apr 4, 2024 · 9 comments
Assignees
Labels
effort: high Complex, time-intensive tasks. priority: high Issue needs to be closed in the next two days. status: completed Issue is completed. type: documentation Improvements or additions to documentation type: planning Planning for the project.

Comments

@SouthAscend
Copy link
Contributor

SouthAscend commented Apr 4, 2024

Description

We need a class diagram for our project

Tasks

  • Create Class Diagrams

Estimated Time

120

Deadline

07/04/2024 - 23.59

Reviewer

@set120120 - 08/04/2024 23.59

@SouthAscend SouthAscend added type: documentation Improvements or additions to documentation priority: high Issue needs to be closed in the next two days. effort: high Complex, time-intensive tasks. status: new Issue is new. type: planning Planning for the project. labels Apr 4, 2024
@semihYILMAZ37 semihYILMAZ37 added status: in progress Issue is in progress. and removed status: new Issue is new. labels Apr 7, 2024
@semihYILMAZ37
Copy link
Contributor

The first draft of the class diagram has been done by @odenizddd , @SouthAscend and I. We faced some unclear points in the requirements. In the next meeting we will discuss those aspects and revise the diagram.

@set120120
Copy link
Contributor

I would like to give a little feedback for the first draft. Do you think it would make sense to keep a list of disliked or blocked posts in RegisteredUser class?

@SouthAscend
Copy link
Contributor Author

Compared to the fields in 'Profile', we thought that 'likedPosts' and 'blockedUsers' were more private information. That's why we put them in "RegisteredUser." However, we can modify it as needed.

@arincdemir arincdemir added this to the Group 5 Milestone 2 milestone Apr 22, 2024
@semihYILMAZ37
Copy link
Contributor

semihYILMAZ37 commented Apr 27, 2024

I revised the diagram according to TA's feedback. The new diagram can be seen here.
@odenizddd @SouthAscend I am open to your feedback on this.

Changes are:

  • corrected the direction of compositions
  • removed feed class
  • added set functions (some of them are add/delete type for list fields)
  • search history has been moved to profile class
  • search engine modified.
  • guestUser class deleted. Usercontroller class added for registration and login.

@SouthAscend
Copy link
Contributor Author

@semihYILMAZ37 Did we remove the feed feature completely or is it just for the class diagram? If the feture remained, why are we removing it from the diagram? Same goes for the guestUser class too. Other than that it seems better with your improvements.

@set120120
Copy link
Contributor

set120120 commented Apr 29, 2024

@odenizddd @semihYILMAZ37 @SouthAscend I think this version looks very nice. It meets all the requirements of feedback.

@semihYILMAZ37
Copy link
Contributor

@semihYILMAZ37 Did we remove the feed feature completely or is it just for the class diagram? If the feture remained, why are we removing it from the diagram? Same goes for the guestUser class too. Other than that it seems better with your improvements.

Feed does not have anything to be stored hence it does not need to have a class. It is just a process. In new diagram, search engine class has a method to return feed for a user. I think returning the feed has similarities with returning search results. Therefore I added feed method to search engine class.

About guest user class, we dont need to store any information of guest user. Then there is no reason to make it a class.

@semihYILMAZ37 semihYILMAZ37 added status: need review Issue is in need of a review. and removed status: in progress Issue is in progress. labels Apr 30, 2024
@semihYILMAZ37
Copy link
Contributor

@set120120 this issue is ready to review.

@set120120
Copy link
Contributor

Everything seems okay. Good job @semihYILMAZ37 @odenizddd @SouthAscend

@set120120 set120120 added status: completed Issue is completed. and removed status: need review Issue is in need of a review. labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: high Complex, time-intensive tasks. priority: high Issue needs to be closed in the next two days. status: completed Issue is completed. type: documentation Improvements or additions to documentation type: planning Planning for the project.
Projects
None yet
Development

No branches or pull requests

5 participants