Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide any comment with just "+1" or ":thumbsup:" [$50] #7

Closed
3 tasks
rappo opened this issue Nov 25, 2014 · 6 comments · May be fixed by #52
Closed
3 tasks

Hide any comment with just "+1" or ":thumbsup:" [$50] #7

rappo opened this issue Nov 25, 2014 · 6 comments · May be fixed by #52
Labels

Comments

@rappo
Copy link

rappo commented Nov 25, 2014

Open to discussion about how to hide the comments without completely losing them

  • Hide any comments with just "+1" or ":thumbsup:"
  • Extension setting to toggle this feature
  • Show a summary ("10 +1 comments were hidden. Show them.")?
  • What about short comments such as "I like this! +1"?
  • Should hidden comments be able to be toggled on per-issue on the issue view itself?

Did you help close this issue? Go claim the $50 bounty on Bountysource.

@rappo rappo changed the title Hide any comment with just "+1" or ":thumbsup:" Hide any comment with just "+1" or ":thumbsup:" [$50] Jan 14, 2015
@rappo rappo added the bounty label Jan 14, 2015
@vegetableman
Copy link

@rappo Would like to work on this. Suggestions:-

Hide any comments with just "+1" or ":thumbsup:"
Extension setting to toggle this feature.

A settings tab on the popup with a checkbox to toggle such comments. Enabled (hide +1 comments) by default. The README says auto-hide is supported already? which seems misleading.

Show a summary ("10 +1 comments were hidden. Show them.")?

Summary of count of hidden comments could be displayed on the settings tab/end of issues page.

What about short comments such as "I like this! +1"?

A bunch of heuristics could be added to hide such comments. But don't think it's worth it, may lead to misnomers. We should settle for +1.

Should hidden comments be able to be toggled on per-issue on the issue view itself?

If we settle only for +1 comments, this would not be needed.

@rappo
Copy link
Author

rappo commented Feb 18, 2015

@vegetableman Great! I'd love to see this added :)

A settings tab on the popup with a checkbox to toggle such comments. Enabled (hide +1 comments) by default.

In Chrome, the standard seems to be to have "Options" if you right click on the icon. This usually takes you to something like chrome-extension://extension/settings/settings.html. We should follow this convention. I'm not sure what the convention is for Firefox, but we should figure that out as Mozilla is relatively strict with their extension approval.

The README says auto-hide is supported already? which seems misleading.

Correct, this is wrong. We need to update it, just haven't yet.

Summary of count of hidden comments could be displayed on the settings tab/end of issues page.

My suggestion is to add an event to the Issue timeline immediately after the first post. Here's a rough mockup:
image

A bunch of heuristics could be added to hide such comments. But don't think it's worth it, may lead to misnomers. We should settle for +1.

Agreed. Let's only hide comments that contain just +1. I think there are three ways that +1 could appear. Plaintext, wrapped with : for the emoji, or "thumbsup" wrapped with : for the same emoji.

Here's a good test issue since there are a bunch of +1s on it: angular/angular.js#1699

@vegetableman
Copy link

Agreed. Thanks for sharing the angular link. Working on it.

@vegetableman
Copy link

Added support for chrome. checkout #52
Will look into firefox.

@vegetableman
Copy link

Added firefox support and refactored the code. Could be merged now.

@rappo
Copy link
Author

rappo commented Feb 27, 2015

👍 Thanks for the contribution!

@rappo rappo closed this as completed Feb 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants