Make travis build all four targets to make sure no file is missing #40
Conversation
| secure: LatJH8j809/6dhEO6WhpQyU3lAjtkOYHAqWD14+bU6lfAc5oRrRFO4B7h56gnIDu6tvYJS0Qa/IhIuB3zZQ/GlG12oivgE/FKp1xXxxHwqjmhPHdetX9YkeAbicJ8YrSQ+C0UC6NMmP1WtU7cmLBV4Q1VwdPnVvRIrOVuWdh3ITUzUz/qQMTZwi+6Z1w92QvxbyytXDqti62NrUq81ba2c7pvBbFBujMp5hyd6+EcuZojYWGNN3cIR2DcPVXD9j4kwLyDPVAcN/OROAwaJlOZ63FbsoUcZULOAX/6s5bmcU1CuYc+eBrXX7KifSqj3yUW00Ea0ynyvsn2GWldAw5b8cYgiLuqQBp3jxtPVH/tEWRdO5TdFtMl8CDEJQiblINjFCXRbnAh8fnk/9jxKTkK+e1DXNQEk/w61+vUB21j74Zw8PhPRvCsoV8XgPkd34UiSlG5XkPaj+vImRpB2/kemYxynpY2Sjq+qoK4iUJy/DXhX/agThWCpjY1hWL2LNL/24mk6DbUHZGVH+4RgoBJxBFCI7ucSp14Og0cCFmhFfsq0nttN+xNegosmHnEcv1Z4tRW750rPf2dgGlXkf6s4msbZ/kyRnccs2zlh3JYYac509Fk98FRNfLb9q0C/jLb0xpg6qf9WbI1QbMcxPHKakyGEUuo+7FO+CLzrJ0qns= | ||
| matrix: | ||
| include: | ||
| - env: JOB="XCODE" DEST="OS=11.4,name=iPhone 8 Plus" SCHEME="Bow" SDK="iphonesimulator" ACTION="test" |
There was a problem hiding this comment.
This JOB env var is not used, is it needed for something?
There was a problem hiding this comment.
You are right, I copied it from an old script and forgot to remove it
.travis.yml
Outdated
| - env: JOB="XCODE" DEST="arch=x86_64" SCHEME="Bow-macOS" SDK="macosx" ACTION="test" | ||
| - env: JOB="XCODE" DEST="OS=11.4,name=Apple TV" SCHEME="Bow-tvOS" SDK="appletvsimulator" ACTION="test" | ||
| - env: JOB="XCODE" DEST="OS=4.3,name=Apple Watch - 42mm" SCHEME="Bow-watchOS" SDK="watchsimulator" ACTION="build" | ||
|
|
||
| before_install: | ||
| - carthage bootstrap |
There was a problem hiding this comment.
Now that we have 4 jobs, we can improve this and build only the needed platform in each case with the flag --platform iOS MacOS etc.
But we can do this in a separate PR :)
|
Thanks! LGTM 👍 Signing is failing on the CI, I've restarted it to see if the error persist. If it still failing I guess we can disable it |
|
It is strange, I don't understand why some of the jobs are passing and others are failing. I have noticed that when they don't run concurrently, they succeed. Are you aware of some issue like this? |
|
Mmm, I tried locally and it was failing too, I have removed the code sign and it seems to work, let's see on travis |
victorg1991
force-pushed
the
trl/travis-builds-all-targets
branch
from
a5f99a9
to
2406e32
Compare
|
I built all 4 targets locally and it was working, but on CI it is still failing due to problems in code signing. Any idea about what we can do? |
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
=======================================
Coverage 78.98% 78.98%
=======================================
Files 167 167
Lines 7410 7410
=======================================
Hits 5853 5853
Misses 1557 1557Continue to review full report at Codecov.
|
|
I changed |
The previous Travis configuration was building only the main target (for iOS). With the new configuration, Travis will build additionally the targets for macOS, watchOS and tvOS, making sure all files are included in all targets and preventing issues like #38.