SourceEditorModels module #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minor changes
miguelangel-dev
force-pushed
the
commands_shared_module
branch
from
caa596f
to
d92ad9f
Compare
truizlop
requested changes
Aug 20, 2020
miguelangel-dev
force-pushed
the
commands_shared_module
branch
2 times, most recently
from
5a72d17
to
63a6d46
Compare
Co-authored-by: Tomás Ruiz-López <truizlop@gmail.com> Update nef-plugin/EditorError.swift result: adding discardableResult to fold
miguelangel-dev
force-pushed
the
commands_shared_module
branch
from
63a6d46
to
73fb91a
Compare
truizlop
requested changes
Sep 10, 2020
truizlop
requested changes
Sep 21, 2020
truizlop
requested changes
Sep 30, 2020
|
|
||
| import Foundation | ||
|
|
||
| enum EditorError: Int, Error { |
There was a problem hiding this comment.
Is there any need to make this an Int backed enum?
There was a problem hiding this comment.
yep, Xcode requires throw errors as NSError and we need setup an error code - you can find the use in terminateError
miguelangel-dev
force-pushed
the
commands_shared_module
branch
from
ae88990
to
7c94905
Compare
truizlop
approved these changes
Oct 5, 2020
Comment on lines
8
to
15
| case .exportSnippetToFile: | ||
| return URLQueryItem(name: key, value: code) | ||
| case .exportSnippetToClipboard: | ||
| return URLQueryItem(name: key, value: code) | ||
| case .markdownPage: | ||
| return URLQueryItem(name: key, value: code) | ||
| case .playgroundBook: | ||
| return URLQueryItem(name: key, value: code) |
There was a problem hiding this comment.
These 4 could be grouped as a single case, as you do below with preferences and about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts common
Commandsmodel from nef-plugin and nef, in a new module calledSourceEditorModels- reducing the duplicity of the code.It keeps sync both modules (plugin and related app), and remove any
stringcheck. Also, it removes these declarations from Info.plist, making the commands typed.