Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code review1 by Fengjun Li #23

Open
Billfengjun opened this issue Dec 9, 2017 · 0 comments
Open

code review1 by Fengjun Li #23

Billfengjun opened this issue Dec 9, 2017 · 0 comments

Comments

@Billfengjun
Copy link

You team did good job on the whole project! You got all file structured and I can not wait to see your final achievement. But there are still some problems that you could solve to make your project better.

The readme is good and it really shows many detail information about your project. While I think it is not easy to understand your project especially for users who know nothing at all. They may need time to search something via google. I think it is better to briefly explain your project in one sentence. Uploading some pictures and videos to explain may also be a good method.

For the structure, all files are perfect ordered. Users can easily find or check what they want.

as for the code,i think it is perfect for you guys to add some commits. It makes user can fully understand what you had done. While I think maybe you can make effort on codes's style to make it easier to understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant