Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version prompt from bower init #1343

Closed
sheerun opened this issue Jun 9, 2014 · 7 comments
Closed

Remove version prompt from bower init #1343

sheerun opened this issue Jun 9, 2014 · 7 comments

Comments

@sheerun
Copy link
Contributor

sheerun commented Jun 9, 2014

Because version has been deprecated in bower spec: https://github.com/bower/bower.json-spec

Right @sindresorhus @benschwarz ?

@sindresorhus
Copy link
Contributor

👍

@unscriptable
Copy link

👎 This breaks RaveJS/rave which does runtime inspection of packages from the browser.

@benschwarz
Copy link
Member

@unscriptable It'll be a major version bump before this change is actually landed via bower init (however effective in the spec [which few people read] immediately).

Can you perhaps describe your usage for version on the relevant spec issue?

@sheerun sheerun modified the milestones: 2.0.0, 1.4.0 Jun 10, 2014
@unscriptable
Copy link

Thanks, @benschwarz. done.

tl;dr: the fact that .bower.json is hidden is preventing us from discovering useful (and vital) meta data. If this meta data is now removed from bower.json, we can no longer discover it.

@sheerun
Copy link
Contributor Author

sheerun commented Jun 13, 2014

@benschwarz Are you sure this should be a major, not a minor bump?

@benschwarz
Copy link
Member

well… even though we're not really using version, others may be relying on it in their scripts / processing.

I think we should deprecate version in the next point release and state its removal for the next major/minor (probably minor, as its not a break in our API as such) release. Sound sane or am I thinking too hard on this?

@sheerun
Copy link
Contributor Author

sheerun commented Jun 19, 2014

@benschwarz I'm not sure how/when state that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants