Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show errors if unable to parse /bowerrc #522

Closed
yosuke-furukawa opened this issue Jun 2, 2013 · 2 comments
Closed

Show errors if unable to parse /bowerrc #522

yosuke-furukawa opened this issue Jun 2, 2013 · 2 comments

Comments

@yosuke-furukawa
Copy link

If .bowerrc has some parse errors, bower would output errors to be better.

eg: my .bowerrc like this

{
  "directory" : "bower_dir", //  last comma is mistaken.
}

then, i execute bower install.

$ bower install jquery

But, bower process exits without any messages.

I fixed this issues, if it is acceptable, i will send PR.

https://github.com/yosuke-furukawa/bower/compare/fix;output_error_when_json_err

@satazor
Copy link
Member

satazor commented Jun 3, 2013

Bower has this check with a friendly error message, see: https://github.com/bower/bower/blob/master/lib/core/config.js#L60

The problem is that tmp module was swallowing uncaught exceptions.
This was fixed in tmp@0.0.20.

@satazor satazor closed this as completed Jun 3, 2013
@yosuke-furukawa
Copy link
Author

I can see an error in my console. Thanks for your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants