Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$.browser.ipad and $.browser.mobile return undefined on iPad Chrome #39

Closed
bjork24 opened this issue Feb 19, 2014 · 4 comments
Closed

Comments

@bjork24
Copy link

bjork24 commented Feb 19, 2014

Using the existing tests, I can't figure out a way to detect mobile chrome. The user agent string contains "Mobile," which might be a good test to add.

@ded
Copy link
Collaborator

ded commented Feb 19, 2014

good find and that's obviously a bug.
quick question. is iPad considered mobile?

@ded
Copy link
Collaborator

ded commented Feb 19, 2014

ok based on scouring google results for is ipad considered mobile — i'm going to omit it as mobile

@ded
Copy link
Collaborator

ded commented Feb 19, 2014

this commit should do the trick 4bba352

@ded ded closed this as completed Feb 19, 2014
@bjork24
Copy link
Author

bjork24 commented Feb 19, 2014

That looks like it will do the trick. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants