feat(annotations): Hide annotations when fullscreen is active (#1195)

* feat(annotations): Hide annotations when fullscreen is active * feat(annotations): Address comments * feat(annotations): Emit event with parameter
box · Apr 9, 2020 · 72471f6 · 72471f6
1 parent 5c3f64b
commit 72471f6
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 7 deletions.
diff --git a/src/lib/constants.js b/src/lib/constants.js
@@ -129,6 +129,7 @@ export const ANNOTATOR_EVENT = {
     fetch: 'annotationsfetched',
     error: 'annotationerror',
     scale: 'scaleannotations',
+    setVisibility: 'annotationsetvisibility',
 };
 
 export const BROWSERS = {

diff --git a/src/lib/viewers/BaseViewer.js b/src/lib/viewers/BaseViewer.js
@@ -545,6 +545,9 @@ class BaseViewer extends EventEmitter {
      */
     handleFullscreenEnter() {
         this.resize();
+        if (this.annotator) {
+            this.annotator.emit(ANNOTATOR_EVENT.setVisibility, false);
+        }
     }
 
     /**
@@ -554,6 +557,9 @@ class BaseViewer extends EventEmitter {
      */
     handleFullscreenExit() {
         this.resize();
+        if (this.annotator) {
+            this.annotator.emit(ANNOTATOR_EVENT.setVisibility, true);
+        }
     }
 
     /**

diff --git a/src/lib/viewers/__tests__/BaseViewer-test.js b/src/lib/viewers/__tests__/BaseViewer-test.js
@@ -16,13 +16,7 @@ let base;
 let containerEl;
 let stubs = {};
 const sandbox = sinon.sandbox.create();
-const ANNOTATOR_EVENT = {
-    modeEnter: 'annotationmodeenter',
-    modeExit: 'annotationmodeexit',
-    fetch: 'annotationsfetched',
-    error: 'annotationerror',
-    scale: 'scaleannotations',
-};
+const { ANNOTATOR_EVENT } = constants;
 
 describe('lib/viewers/BaseViewer', () => {
     before(() => {
@@ -532,20 +526,28 @@ describe('lib/viewers/BaseViewer', () => {
     describe('handleFullscreenEnter()', () => {
         it('should resize the viewer', () => {
             sandbox.stub(base, 'resize');
+            base.annotator = {
+                emit: sandbox.mock(),
+            };
 
             base.handleFullscreenEnter();
 
             expect(base.resize).to.be.called;
+            expect(base.annotator.emit).to.be.calledWith(ANNOTATOR_EVENT.setVisibility, false);
         });
     });
 
     describe('handleFullscreenExit()', () => {
         it('should resize the viewer', () => {
             sandbox.stub(base, 'resize');
+            base.annotator = {
+                emit: sandbox.mock(),
+            };
 
             base.handleFullscreenExit();
 
             expect(base.resize).to.be.called;
+            expect(base.annotator.emit).to.be.calledWith(ANNOTATOR_EVENT.setVisibility, true);
         });
     });