Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(annotation): handle create event #1199

Merged
merged 3 commits into from
Apr 17, 2020
Merged

feat(annotation): handle create event #1199

merged 3 commits into from
Apr 17, 2020

Conversation

ConradJChan
Copy link
Contributor

@ConradJChan ConradJChan commented Apr 16, 2020 •
edited

Updated the create event to annotations_create and added logic to toggleAnnotationMode and set the active annotation id in the annotator

Todo:

  • unit tests

@ConradJChan ConradJChan requested a review from a team as a code owner April 16, 2020 23:23
jstoffan
jstoffan previously approved these changes Apr 17, 2020
View reviewed changes
@ConradJChan ConradJChan merged commit 888b4ae into box:master Apr 17, 2020
@ConradJChan ConradJChan deleted the handle-create-event branch April 17, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxiao6 mxiao6 mxiao6 approved these changes

@jstoffan jstoffan jstoffan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ConradJChan @jstoffan @mxiao6