feat(annotations tooltip): Close on click outside to avoid UI issues #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
as a 
jstoffan
reviewed
May 21, 2021
| shouldTarget={isEnabled} | ||
| showCloseButton | ||
| tetherElementClassName="bp-AnnotationsTooltipTether" |
There was a problem hiding this comment.
Just to confirm: Is this change intentional? Is the increased z-index no longer needed?
There was a problem hiding this comment.
@jstoffan - Correct, we no longer need the z-index, because if we click on the share button which opens the modal that was causing the z-index issue the tooltip will now close so it's not a problem
jstoffan
approved these changes
May 21, 2021
ghost
commented
May 21, 2021
| shouldTarget={isEnabled} | ||
| showCloseButton | ||
| tetherElementClassName="bp-AnnotationsTooltipTether" |
There was a problem hiding this comment.
we no longer need this as the tooltip will close if the preview share modal is clicked
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.