feat(thumbnails): remove thumbnail toggle on small modalities #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanthai
force-pushed
the
remove-thumbnail-toggle-small
branch
2 times, most recently
from
6d4cc17
to
1bce90c
Compare
|
Seems like it would make sense to convert the other thumbnail component CSS to the new breakpoints...probably should define that breakpoint number in BUIE |
ivanthai
force-pushed
the
remove-thumbnail-toggle-small
branch
from
1bce90c
to
bb31bb3
Compare
|
@ivanthai, are we planning to unify the breakpoints? I think we'll run into some odd behaviors otherwise. |
ivanthai
force-pushed
the
remove-thumbnail-toggle-small
branch
from
bb31bb3
to
bdb2654
Compare
jstoffan
reviewed
Jul 1, 2022
ivanthai
force-pushed
the
remove-thumbnail-toggle-small
branch
from
bdb2654
to
6f5b21e
Compare
jstoffan
approved these changes
Jul 2, 2022
jstoffan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please approve #1448 first
This is hidden on smaller modalities in order to prioritize other functions
https://zpl.io/dxDDLEp