Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(annotations): remove zoom ctrls on mobile #1451

Merged
merged 1 commit into from Jun 14, 2022

Conversation

ivanthai
Copy link
Collaborator

Remove zoom controls on touch devices with small-medium screen widths (<767px). Touch devices in this case refer to mobile. However, mobile seems more like a subset of touch devices to me. Perhaps this is an edge case we can ignore.

https://zpl.io/dxDDLEp

image

annotations-remove-zoom-mobile

@ivanthai ivanthai requested a review from a team as a code owner June 14, 2022 01:49
Copy link
Contributor

@bfoxx1906 bfoxx1906 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ivanthai ivanthai merged commit 7e92795 into box:master Jun 14, 2022
@ivanthai ivanthai deleted the remove-zoom-ctrls-on-mobile branch June 14, 2022 20:10
karelee7 pushed a commit to jstoffan/box-content-preview that referenced this pull request Jun 23, 2022
Co-authored-by: Ivan Thai <ithai@box.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants