Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Deprecate use_index param from MDQ of files/folders #666

Merged
merged 1 commit into from Jan 31, 2022
Merged

feat: Deprecate use_index param from MDQ of files/folders #666

merged 1 commit into from Jan 31, 2022

Conversation

lukaszsocha2
Copy link
Contributor

Closes: SDK-1938

@coveralls
Copy link

coveralls commented Jan 27, 2022 •
edited

Pull Request Test Coverage Report for Build 2820

  • 13 of 15 (86.67%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 93.635%
Changes Missing Coverage Covered Lines Changed/Added Lines %
boxsdk/util/deprecation_decorator.py 10 12 83.33%
Totals Coverage Status
Change from base Build 2818: -0.04%
Covered Lines: 3251
Relevant Lines: 3472
💛 - Coveralls

@lukaszsocha2 lukaszsocha2 force-pushed the sdk-1938-deprecate-use_index_param_from_mdq branch from 8efb739 to 92b4086 Compare January 28, 2022 11:22
antusus
antusus approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@antusus antusus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukaszsocha2 lukaszsocha2 merged commit 2595720 into main Jan 31, 2022
@lukaszsocha2 lukaszsocha2 deleted the sdk-1938-deprecate-use_index_param_from_mdq branch January 31, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antusus antusus antusus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukaszsocha2 @coveralls @antusus