Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: UploadSession.commit returns None when retry limit was reached #696

Merged
merged 10 commits into from Feb 11, 2022
Merged

fix: UploadSession.commit returns None when retry limit was reached #696

merged 10 commits into from Feb 11, 2022

Conversation

antusus
Copy link
Contributor

@antusus antusus commented Feb 11, 2022

  • chore: Updated documentation on UploadSession and ChunkedUploader
  • chore: Mark File returned by UploadSession.commit, ChunkedUploader.start and ChunkedUploader.resume as optional

@coveralls
Copy link

coveralls commented Feb 11, 2022 •
edited

Pull Request Test Coverage Report for Build 1828975143

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 93.59%
Totals Coverage Status
Change from base Build 1828891406: 0.004%
Covered Lines: 3256
Relevant Lines: 3479
💛 - Coveralls

lukaszsocha2
lukaszsocha2 approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@lukaszsocha2 lukaszsocha2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@antusus antusus merged commit 9456fe0 into main Feb 11, 2022
@antusus antusus deleted the sdk-1987_commit_when_202_returned branch February 11, 2022 12:15
@arjankowski arjankowski mentioned this pull request Feb 11, 2022
Closed
@lukaszsocha2
Copy link
Contributor

Fixes: #685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszsocha2 lukaszsocha2 lukaszsocha2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@antusus @coveralls @lukaszsocha2