Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Replace external mock package with Python standard library unittest.mock #697

Merged
merged 1 commit into from Feb 15, 2022
Merged

feat: Replace external mock package with Python standard library unittest.mock #697

merged 1 commit into from Feb 15, 2022

Conversation

lukaszsocha2
Copy link
Contributor

Closes: SDK-2005

@lukaszsocha2 lukaszsocha2 force-pushed the sdk-2005-remove-mock-library-dependency branch from 1378057 to b30b1be Compare February 14, 2022 13:36
@lukaszsocha2 lukaszsocha2 changed the title feat: Replace external mock with Python standard library `unittest.mock' feat: Replace external mock package with Python standard library unittest.mock Feb 14, 2022
@coveralls
Copy link

coveralls commented Feb 14, 2022 •
edited

Pull Request Test Coverage Report for Build 1841341344

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.59%
Totals Coverage Status
Change from base Build 1829224395: 0.0%
Covered Lines: 3256
Relevant Lines: 3479
💛 - Coveralls

@lukaszsocha2 lukaszsocha2 mentioned this pull request Feb 14, 2022
Closed
antusus
antusus approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@antusus antusus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukaszsocha2 lukaszsocha2 merged commit 6fd6366 into main Feb 15, 2022
@lukaszsocha2 lukaszsocha2 deleted the sdk-2005-remove-mock-library-dependency branch February 15, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antusus antusus antusus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukaszsocha2 @coveralls @antusus