Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add setting disposition_at field for files under retention #710

Merged
merged 7 commits into from Mar 10, 2022
Merged

feat: Add setting disposition_at field for files under retention #710

merged 7 commits into from Mar 10, 2022

Conversation

lukaszsocha2
Copy link
Contributor

Closes: SDK-1921

@coveralls
Copy link

coveralls commented Mar 8, 2022 •
edited

Pull Request Test Coverage Report for Build 1958221876

  • 16 of 16 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 93.574%
Totals Coverage Status
Change from base Build 1957689642: 0.03%
Covered Lines: 3291
Relevant Lines: 3517
💛 - Coveralls

antusus
antusus previously approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@antusus antusus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

boxsdk/util/datetime_formatter.py Show resolved Hide resolved
antusus
antusus approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@antusus antusus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukaszsocha2 lukaszsocha2 merged commit 91b1373 into main Mar 10, 2022
@lukaszsocha2 lukaszsocha2 deleted the sdk-1921-update-extend-retention-via-files-api branch March 10, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antusus antusus antusus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukaszsocha2 @coveralls @antusus