Skip to content

Commit

Permalink
feat: remove browser support for IE11 (#3382)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Internet Explorer 11 is no longer supported
  • Loading branch information
tjuanitas committed Aug 11, 2023
1 parent d940782 commit e151c87
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 17 deletions.
3 changes: 1 addition & 2 deletions DEVELOPING.md
Expand Up @@ -16,7 +16,7 @@ Our development setup assumes a LINUX/BSD environemnt.

A published version of the style guide can be seen at https://opensource.box.com/box-ui-elements/. The style guide uses **_live_** demo data within the UI Elements. Due to security restrictions this data is read-only. You can run a local version of the style guide as follows:

1. Start the style guide server via `yarn start` (or via `yarn start:examples:legacy`, to include support for IE 11).
1. Start the style guide server via `yarn start`.
2. Navigate to `http://localhost:6060/` to see the UI Elements in action. If testing on a different machine or VM, you can instead use the IP address shown on your terminal window.

**_NOTE:_** _This note applies to testing top level UI Elements only and not the lower level components. If you want to use your own live data for the style guide, then start the style guide server using [your own developer auth token](https://developer.box.com/docs/authenticate-with-developer-token) and a file or folder ID via_
Expand Down Expand Up @@ -72,7 +72,6 @@ To test the Box UI Elements with your own project use local Yarn linking.
## Common Script Commands

- `yarn start` to launch a local style guide examples server. Uses demo live data for Elements.
- `yarn start:examples:legacy` same as above, but with IE 11 support.
- `yarn start:npm` to symlink Elements via `yarn link` to a parent project.
- `yarn start:dev` to launch a local webpack dev server. Uses your own data for Elements.
- `yarn lint` to lint js and css.
Expand Down
1 change: 0 additions & 1 deletion README.md
Expand Up @@ -54,7 +54,6 @@ Box UI Elements use [SCSS stylesheets](https://sass-lang.com/guide). Each of the

### Browser Support
* Desktop Chrome, Firefox, Safari, Edge (latest 2 versions)
* Limited support for Internet Explorer 11 (requires ES2015 polyfill)
* Mobile Chrome and Safari

### Supported Packages
Expand Down
5 changes: 1 addition & 4 deletions package.json
Expand Up @@ -76,11 +76,9 @@
"start": "npm-run-all setup start:examples",
"start:dev": "yarn setup; LANGUAGE=en-US BABEL_ENV=development NODE_ENV=development NODE_OPTIONS=--openssl-legacy-provider node --max_old_space_size=8192 node_modules/webpack-dev-server/bin/webpack-dev-server.js --config scripts/webpack.config.js --mode development",
"start:examples": "EXAMPLES=true LANGUAGE=en-US REACT=true BABEL_ENV=development NODE_ENV=development NODE_OPTIONS=--openssl-legacy-provider node --max_old_space_size=8192 node_modules/react-styleguidist/bin/styleguidist.js server --config scripts/styleguide.config.js --mode development",
"start:examples:legacy": "BROWSERSLIST_ENV=production yarn start:examples",
"start:npm": "yarn setup; yarn build:dev:es",
"start:storybook": "LANGUAGE=en-US REACT=true BABEL_ENV=development NODE_ENV=development NODE_OPTIONS=--openssl-legacy-provider start-storybook -p 6061",
"start:storybook:ci": "yarn start:storybook --ci",
"start:storybook:legacy": "BROWSERSLIST_ENV=production yarn start:storybook",
"test": "BABEL_ENV=test NODE_ENV=test yarn jest -c scripts/jest/jest.config.js",
"test:e2e": "BROWSERSLIST_ENV=test npm-run-all -p -r start:examples cy:run",
"test:e2e:open": "BROWSERSLIST_ENV=test npm-run-all -p -r start:examples cy:open",
Expand All @@ -96,8 +94,7 @@
"last 2 Firefox versions",
"last 2 Safari versions",
"last 2 Edge versions",
"last 2 iOS versions",
"IE 11"
"last 2 iOS versions"
],
"development": ["last 1 Chrome versions", "last 1 Firefox versions", "last 1 Safari versions"]
},
Expand Down
9 changes: 0 additions & 9 deletions src/elements/README.md
Expand Up @@ -9,12 +9,3 @@ The UI Elements use [react-intl](https://github.com/formatjs/react-intl) for int
The `language` property is a string that can be one of `en-AU`, `en-CA`, `en-GB`, `en-US`, `bn-IN`, `da-DK`, `de-DE`, `es-419`, `es-ES`, `fi-FI`, `fr-CA`, `fr-FR`, `hi-IN`, `it-IT`, `ja-JP`, `ko-KR`, `nb-NO`, `nl-NL`, `pl-PL`, `pt-BR`, `ru-RU`, `sv-SE`, `tr-TR`, `zh-CN`, `zh-TW`.

The `messages` property is a map of message keys and translated strings. All the messages that the UI elements use can be found under the [i18n](i18n) folder. We distribute them as JS modules within the `box-ui-elements` npm package and they can be imported like any other module - `import box-ui-elements/i18n/[LANGUAGE FROM ABOVE]`. The code examples for each of the UI Elements assume `en-US` and show how the US english messages are imported in.

For `react-intl` to work properly, please look at its [requirements](https://github.com/formatjs/react-intl/blob/master/docs/Getting-Started.md#runtime-requirements). You may need to polyfill [Intl](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl) if you are supporting older browsers. One approach can be to import polyfills within your own application via:

```js static
import '@formatjs/intl-pluralrules/dist-es6/polyfill';
import '@formatjs/intl-relativetimeformat/dist-es6/polyfill';
```


1 change: 0 additions & 1 deletion test/openwith.html
Expand Up @@ -26,7 +26,6 @@
}
</style>
<link rel="stylesheet" type="text/css" href="../dev/en-US/openwith.css" />
<script src="https://cdn.polyfill.io/v2/polyfill.js?features=es6,Intl"></script>
<script src="../dev/en-US/openwith.js"></script>
</head>
<body>
Expand Down

0 comments on commit e151c87

Please sign in to comment.