Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for a custom HttpMessageHandler to be provided to the internal HttpClient instance #303

Open
bobstanton opened this issue Mar 31, 2017 · 2 comments

Comments

@bobstanton
Copy link

Gathering tracing metrics for an application's Http requests can be done easily with a custom HttpMessageHandler as seen here: http://stackoverflow.com/a/18925296

In order to get this behavior with the current version of the Box SDK, an entire HttpRequestHandler class needs to be provided to the BoxClient. A lighter weight alternative where by a HttpMessageHandler can be provided is preferred.

@ghost
Copy link

ghost commented Feb 7, 2018

Allowing for a custom HttpMessageHandler would also benefit testability: https://github.com/richardszalay/mockhttp#how

@mattwiller
Copy link
Contributor

@bobstanton @Nyxel We'll add it to our backlog to investigate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants