Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add content-type field to sign request #850

Merged
merged 4 commits into from Aug 23, 2022
Merged

feat: Add content-type field to sign request #850

merged 4 commits into from Aug 23, 2022

Conversation

congminh1254
Copy link
Member

Closes: SDK-2252

mwwoda
mwwoda reviewed Aug 23, 2022
View reviewed changes
Copy link
Contributor

@mwwoda mwwoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment regarding adding assert to tests.

Box.V2.Test/Fixtures/BoxSignRequest/GetSignRequest200.json Show resolved Hide resolved
mwwoda
mwwoda approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@mwwoda mwwoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@congminh1254 congminh1254 merged commit 054d3e1 into main Aug 23, 2022
@congminh1254 congminh1254 deleted the sdk-2252-add-content-type-field branch August 23, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwwoda mwwoda mwwoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@congminh1254 @mwwoda