Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: BoxCCGAuth add User and Admin clients factory methods without initial token #883

Merged
merged 6 commits into from Jan 13, 2023

Conversation

JanVargovsky
Copy link
Contributor

Fixes #879

@JanVargovsky
Copy link
Contributor Author

I can update (simplify) the documentation if the code looks OK.

@mwwoda
Copy link
Contributor

mwwoda commented Jan 13, 2023

Really cool to see your contribution!

I can update (simplify) the documentation if the code looks OK.

If you don't mind go ahead. The code looks fine to me. Just one missing thing I mentioned in another comment

@JanVargovsky
Copy link
Contributor Author

I'm not the best at writing docu, so hopefully, it makes sense. There were invalid links, so I've updated them. You can review it now.

Do I have to fix something myself to make integration tests pass? based on CI log it seems like it's not configured.

Copy link
Contributor

@mwwoda mwwoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch with old links! Just a small typo and we are ready to go 🚀

docs/authentication.md Outdated Show resolved Hide resolved
@mwwoda
Copy link
Contributor

mwwoda commented Jan 13, 2023

Do I have to fix something myself to make integration tests pass? based on CI log it seems like it's not configured.

The integration tests use some preconfigured account that calls the Box API directly. Since this account needs credentials which are stored as secrets, this workflow is restricted to internal collaborators to prevent malicious code that could be triggered by the fork (like leaking the secrets). Tests will be run on the main branch when we merge this PR.

@mwwoda
Copy link
Contributor

mwwoda commented Jan 13, 2023

Thanks @JanVargovsky once again for your input. It's always nice to see contributions from the community. I'll try to release a new package to nuget with these changes early next week to make it easier to access this feature. Have a great weekend!

@mwwoda mwwoda merged commit c1337fc into box:main Jan 13, 2023
@JanVargovsky
Copy link
Contributor Author

I get the security perspective, I just thought that it would pass, you just have to run it manually. Thanks for the review :)

@JanVargovsky JanVargovsky deleted the feat/ccg-auth-optional-initial-token branch January 13, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server Auth with CCG - initial setup for DI container registration
2 participants