Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for vanity_name when creating shared-links #524

Merged
merged 1 commit into from Mar 4, 2024
Merged

feat: Add support for vanity_name when creating shared-links #524

merged 1 commit into from Mar 4, 2024

Conversation

arjankowski
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8123059610

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 86.575%
Totals Coverage Status
Change from base Build 8017909042: 0.009%
Covered Lines: 4197
Relevant Lines: 4695
💛 - Coveralls

mwwoda
mwwoda approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@mwwoda mwwoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arjankowski arjankowski merged commit 38164bc into main Mar 4, 2024
13 checks passed
@arjankowski arjankowski deleted the aj/SDK-3669 branch March 4, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwwoda mwwoda mwwoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arjankowski @coveralls @mwwoda