-
Notifications
You must be signed in to change notification settings - Fork 60
/
test_flaky_pytest_plugin.py
580 lines (504 loc) · 15.4 KB
/
test_flaky_pytest_plugin.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
# coding: utf-8
from __future__ import unicode_literals
from io import StringIO
from mock import Mock, patch
# pylint:disable=import-error
import pytest
from _pytest.runner import CallInfo
# pylint:enable=import-error
from flaky import flaky
from flaky import _flaky_plugin
from flaky.flaky_pytest_plugin import (
call_runtest_hook,
FlakyPlugin,
FlakyXdist,
PLUGIN,
)
from flaky.names import FlakyNames
from flaky.utils import unicode_type
@pytest.fixture
def mock_io(monkeypatch):
mock_string_io = StringIO()
def string_io():
return mock_string_io
monkeypatch.setattr(_flaky_plugin, 'StringIO', string_io)
return mock_string_io
@pytest.fixture
def string_io():
return StringIO()
@pytest.fixture
def flaky_plugin(mock_io):
# pylint:disable=unused-argument
return FlakyPlugin()
@pytest.fixture
def mock_plugin_rerun(monkeypatch, flaky_plugin):
calls = []
def rerun_test(test):
calls.append(test)
monkeypatch.setattr(flaky_plugin, '_mark_test_for_rerun', rerun_test)
def get_calls():
return calls
return get_calls
@pytest.fixture(params=['instance', 'module', 'parent'])
def flaky_test(request, mock_config):
def test_function():
pass
test_owner = Mock()
setattr(test_owner, 'test_method', test_function)
setattr(test_owner, 'obj', test_owner)
kwargs = {request.param: test_owner}
test = MockTestItem(**kwargs)
setattr(test, 'owner', test_owner)
setattr(test, 'config', mock_config)
return test
@pytest.fixture
def call_info(flaky_test):
return MockFlakyCallInfo(flaky_test, 'call')
@pytest.fixture
def mock_error():
return MockError()
class MockError(object):
def __init__(self):
super(MockError, self).__init__()
self.type = Mock()
self.value = Mock()
self.value.message = 'failed'
self.traceback = Mock()
class MockTestItem(object):
name = 'test_method'
instance = None
module = None
parent = None
def __init__(self, instance=None, module=None, parent=None):
if instance is not None:
self.instance = instance
if module is not None:
self.module = module
if parent is not None:
self.parent = parent
def runtest(self):
pass
class MockConfig(object):
def getvalue(self, key):
# pylint:disable=unused-argument,no-self-use
return False
def getoption(self, key, default):
# pylint:disable=unused-argument,no-self-use
return default
@pytest.fixture
def mock_config():
return MockConfig()
class MockFlakyCallInfo(CallInfo):
def __init__(self, item, when):
# pylint:disable=super-init-not-called
# super init not called because it has unwanted side effects
self.when = when
self._item = item
def test_flaky_plugin_report(flaky_plugin, mock_io, string_io):
flaky_report = 'Flaky tests passed; others failed. ' \
'No more tests; that ship has sailed.'
expected_string_io = StringIO()
expected_string_io.write('===Flaky Test Report===\n\n')
expected_string_io.write(flaky_report)
expected_string_io.write('\n===End Flaky Test Report===\n')
mock_io.write(flaky_report)
flaky_plugin.pytest_terminal_summary(string_io)
assert string_io.getvalue() == expected_string_io.getvalue()
@pytest.fixture(params=(
{},
{'flaky_report': ''},
{'flaky_report': 'ŝȁḿҏľȅ ƭȅхƭ'},
))
def mock_xdist_node_workeroutput(request):
return request.param
@pytest.fixture(params=(None, object()))
def mock_xdist_error(request):
return request.param
@pytest.mark.parametrize('assign_workeroutput', (True, False))
def test_flaky_xdist_nodedown(
mock_xdist_node_workeroutput,
assign_workeroutput,
mock_xdist_error
):
flaky_xdist = FlakyXdist(PLUGIN)
node = Mock()
if assign_workeroutput:
node.workeroutput = mock_xdist_node_workeroutput
else:
delattr(node, 'workeroutput')
delattr(node, 'slaveoutput')
mock_stream = Mock(StringIO)
with patch.object(PLUGIN, '_stream', mock_stream):
flaky_xdist.pytest_testnodedown(node, mock_xdist_error)
if assign_workeroutput and 'flaky_report' in mock_xdist_node_workeroutput:
mock_stream.write.assert_called_once_with(
mock_xdist_node_workeroutput['flaky_report'],
)
else:
assert not mock_stream.write.called
_REPORT_TEXT1 = 'Flaky report text'
_REPORT_TEXT2 = 'Ḿőŕȅ ƒľȁƙŷ ŕȅҏőŕƭ ƭȅхƭ'
@pytest.mark.parametrize('initial_report,stream_report,expected_report', (
('', '', ''),
('', _REPORT_TEXT1, _REPORT_TEXT1),
(_REPORT_TEXT1, '', _REPORT_TEXT1),
(_REPORT_TEXT1, _REPORT_TEXT2, _REPORT_TEXT1 + _REPORT_TEXT2),
(_REPORT_TEXT2, _REPORT_TEXT1, _REPORT_TEXT2 + _REPORT_TEXT1),
))
def test_flaky_session_finish_copies_flaky_report(
initial_report,
stream_report,
expected_report,
):
PLUGIN.stream.seek(0)
PLUGIN.stream.truncate()
PLUGIN.stream.write(stream_report)
PLUGIN.config = Mock()
PLUGIN.config.workeroutput = {'flaky_report': initial_report}
PLUGIN.pytest_sessionfinish()
assert PLUGIN.config.workeroutput['flaky_report'] == expected_report
def test_flaky_plugin_can_suppress_success_report(
flaky_test,
flaky_plugin,
call_info,
string_io,
mock_io,
):
flaky()(flaky_test)
# pylint:disable=protected-access
flaky_plugin._flaky_success_report = False
# pylint:enable=protected-access
call_info.when = 'call'
actual_plugin_handles_success = flaky_plugin.add_success(flaky_test)
assert actual_plugin_handles_success is False
assert string_io.getvalue() == mock_io.getvalue()
def test_flaky_plugin_raises_errors_in_fixture_setup(
flaky_test,
flaky_plugin,
string_io,
mock_io,
):
"""
Test for Issue #57 - fixtures which raise an error should show up as
test errors.
This test ensures that exceptions occurring when running a test
fixture are copied into the call info's excinfo field.
"""
def error_raising_setup_function(item):
assert item is flaky_test
item.ran_setup = True
return 5 / 0
flaky()(flaky_test)
flaky_test.ihook = Mock()
flaky_test.ihook.pytest_runtest_setup = error_raising_setup_function
flaky_plugin._call_infos[flaky_test] = {} # pylint:disable=protected-access
call_info = call_runtest_hook(flaky_test, 'setup')
assert flaky_test.ran_setup
assert string_io.getvalue() == mock_io.getvalue()
assert call_info.excinfo.type is ZeroDivisionError
class TestFlakyPytestPlugin(object):
_test_method_name = 'test_method'
def test_flaky_plugin_handles_success(
self,
flaky_test,
flaky_plugin,
call_info,
string_io,
mock_io,
):
self._test_flaky_plugin_handles_success(
flaky_test,
flaky_plugin,
call_info,
string_io,
mock_io,
)
def test_flaky_plugin_handles_success_for_needs_rerun(
self,
flaky_test,
flaky_plugin,
call_info,
string_io,
mock_io,
mock_plugin_rerun,
):
self._test_flaky_plugin_handles_success(
flaky_test,
flaky_plugin,
call_info,
string_io,
mock_io,
min_passes=2,
)
assert mock_plugin_rerun()[0] == flaky_test
def test_flaky_plugin_ignores_success_for_non_flaky_test(
self,
flaky_plugin,
flaky_test,
call_info,
string_io,
mock_io,
):
flaky_plugin.add_success(flaky_test)
self._assert_test_ignored(mock_io, string_io, call_info)
def test_flaky_plugin_ignores_failure_for_non_flaky_test(
self,
flaky_plugin,
flaky_test,
call_info,
string_io,
mock_io,
):
flaky_plugin.add_failure(flaky_test, None)
self._assert_test_ignored(mock_io, string_io, call_info)
def test_flaky_plugin_handles_failure(
self,
flaky_test,
flaky_plugin,
call_info,
string_io,
mock_io,
mock_error,
mock_plugin_rerun,
):
self._test_flaky_plugin_handles_failure(
flaky_test,
flaky_plugin,
call_info,
string_io,
mock_io,
mock_error,
)
assert mock_plugin_rerun()[0] == flaky_test
def test_flaky_plugin_handles_failure_for_no_more_retries(
self,
flaky_test,
flaky_plugin,
call_info,
string_io,
mock_io,
mock_error,
):
self._test_flaky_plugin_handles_failure(
flaky_test,
flaky_plugin,
call_info,
string_io,
mock_io,
mock_error,
max_runs=1,
)
def test_flaky_plugin_handles_additional_failures(
self,
flaky_test,
flaky_plugin,
call_info,
string_io,
mock_io,
mock_error,
mock_plugin_rerun,
):
self._test_flaky_plugin_handles_failure(
flaky_test,
flaky_plugin,
call_info,
string_io,
mock_io,
mock_error,
current_errors=[None],
)
assert mock_plugin_rerun()[0] == flaky_test
def _assert_flaky_attributes_contains(
self,
expected_flaky_attributes,
test,
):
actual_flaky_attributes = self._get_flaky_attributes(test)
assert all(
item in actual_flaky_attributes.items()
for item in expected_flaky_attributes.items()
)
def test_flaky_plugin_exits_after_false_rerun_filter(
self,
flaky_test,
flaky_plugin,
call_info,
string_io,
mock_io,
mock_error,
mock_plugin_rerun,
):
err_tuple = (mock_error.type, mock_error.value, mock_error.traceback)
def rerun_filter(err, name, test, plugin):
assert err == err_tuple
assert name == flaky_test.name
assert test is flaky_test
assert plugin is flaky_plugin
return False
flaky(rerun_filter=rerun_filter)(flaky_test)
call_info.when = 'call'
actual_plugin_handles_failure = flaky_plugin.add_failure(
flaky_test,
mock_error,
)
assert actual_plugin_handles_failure is False
assert not mock_plugin_rerun()
string_io.writelines([
self._test_method_name,
' failed and was not selected for rerun.',
'\n\t',
unicode_type(mock_error.type),
'\n\t',
unicode_type(mock_error.value),
'\n\t',
unicode_type(mock_error.traceback),
'\n',
])
assert string_io.getvalue() == mock_io.getvalue()
@staticmethod
def _assert_test_ignored(mock_io, string_io, call_info):
assert call_info
assert mock_io.getvalue() == string_io.getvalue()
def _test_flaky_plugin_handles_success(
self,
test,
plugin,
info,
stream,
mock_stream,
current_passes=0,
current_runs=0,
max_runs=2,
min_passes=1,
):
flaky(max_runs, min_passes)(test)
setattr(
test,
FlakyNames.CURRENT_PASSES,
current_passes,
)
setattr(
test,
FlakyNames.CURRENT_RUNS,
current_runs,
)
too_few_passes = current_passes + 1 < min_passes
retries_remaining = current_runs + 1 < max_runs
expected_plugin_handles_success = too_few_passes and retries_remaining
info.when = 'call'
actual_plugin_handles_success = plugin.add_success(test)
assert expected_plugin_handles_success == actual_plugin_handles_success
self._assert_flaky_attributes_contains(
{
FlakyNames.CURRENT_PASSES: current_passes + 1,
FlakyNames.CURRENT_RUNS: current_runs + 1,
},
test,
)
stream.writelines([
self._test_method_name,
" passed {} out of the required {} times. ".format(
current_passes + 1, min_passes,
),
])
if expected_plugin_handles_success:
stream.write(
'Running test again until it passes {} times.\n'.format(
min_passes,
),
)
else:
stream.write('Success!\n')
assert stream.getvalue() == mock_stream.getvalue()
def _test_flaky_plugin_handles_failure(
self,
test,
plugin,
info,
stream,
mock_stream,
mock_error,
current_errors=None,
current_passes=0,
current_runs=0,
max_runs=2,
min_passes=1,
rerun_filter=None,
):
flaky(max_runs, min_passes, rerun_filter)(test)
if current_errors is None:
current_errors = [None]
else:
current_errors.append(None)
setattr(
test,
FlakyNames.CURRENT_ERRORS,
current_errors,
)
setattr(
test,
FlakyNames.CURRENT_PASSES,
current_passes,
)
setattr(
test,
FlakyNames.CURRENT_RUNS,
current_runs,
)
too_few_passes = current_passes < min_passes
retries_remaining = current_runs + 1 < max_runs
expected_plugin_handles_failure = too_few_passes and retries_remaining
info.when = 'call'
actual_plugin_handles_failure = plugin.add_failure(
test,
mock_error,
)
assert expected_plugin_handles_failure == actual_plugin_handles_failure
self._assert_flaky_attributes_contains(
{
FlakyNames.CURRENT_RUNS: current_runs + 1,
FlakyNames.CURRENT_ERRORS: current_errors
},
test,
)
if expected_plugin_handles_failure:
stream.writelines([
self._test_method_name,
' failed ({} runs remaining out of {}).'.format(
max_runs - current_runs - 1, max_runs
),
'\n\t',
unicode_type(mock_error.type),
'\n\t',
unicode_type(mock_error.value),
'\n\t',
unicode_type(mock_error.traceback),
'\n',
])
else:
message = ' failed; it passed {0} out of the required {1} times.'
stream.writelines([
self._test_method_name,
message.format(
current_passes,
min_passes
),
'\n\t',
unicode_type(mock_error.type),
'\n\t',
unicode_type(mock_error.value),
'\n\t',
unicode_type(mock_error.traceback),
'\n',
])
assert stream.getvalue() == mock_stream.getvalue()
@staticmethod
def _get_flaky_attributes(test):
actual_flaky_attributes = {
attr: getattr(
test,
attr,
None,
) for attr in FlakyNames()
}
return actual_flaky_attributes