including other modules not working

[kyleprager]

I have successfully forked "our-boxen" and installed it on my Macbook. Now I want to add Cassandra, which has a few requirements. When I tried to include cassandra and it's requirements (java, etc.) in my "site.pp" file it didn't work. I then tried a module with no dependencies, VLC, which I included like so:

node default {
  # core modules, needed for most things
  include dnsmasq
  include git
  include hub
  include nginx
  include nvm
  include ruby

  # modules I've added
  include vlc

But I keep getting the following error when I run "script/boxen" after including vlc in my "sites.pp" file:

Error: Could not find class vlc for kyles-macbook-pro.local on node kyles-macbook-pro.local

So my procedure is:

1. Edit "sites.pp" to include vlc
2. Run "scripts/boxen"
3. I get the above error

Am I not following the proper procedure for adding modules? If you have any advice that would be awesome!

[roderik]

Check out the Puppetfile in the root, this defines the dependencies that should be downloaded

[kyleprager]

I put this line inside my Puppetfile at the root level:

github "java",     "1.0.0"

And I put this inside my "manifests/site.pp" file:

include java

I then ran:

script/boxen --no-fde

and it gave me the following error message:

Error: Mac OS X PKG DMG's must specify a source string ending in .dmg or flat .pkg file
Error: /Stage[main]/Java/Package[jre-7u13-macosx-x64.dmg]/ensure: change from absent to present failed: Mac OS X PKG DMG's must specify a source string ending in .dmg or flat .pkg file
Notice: /Stage[main]/Java/File[/opt/boxen/bin/java]: Dependency Package[jre-7u13-macosx-x64.dmg] has failures: true
Warning: /Stage[main]/Java/File[/opt/boxen/bin/java]: Skipping because of failed dependencies

I'm not sure where the "1.0.0" version number comes from, I tried poking around files to see if it was defined in the puppet-java repository but I couldn't find anything. I really appreciate the help on this, I'm excited about the project and I want to get Cassandra and Solr to work for a rails project.

[roderik]

Java is this: github "java", "1.0.5"

Check out the repo for this module and use the latest tag. This works for me in a clean VM.

[kyleprager]

Ahhh the number is the latest tag in git. Duh. Should have thought of that. Thanks!

[kyleprager]

It should be documented, either in each puppet-xxxx repo's README.md file or the our-boxen repo or somewhere, that you have to make an entry in your Puppetfile to have an include work in your site.pp file.

[kyleprager]

I documented this in the README.md and the pull request was accepted. Pull request #53