-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflows on main
#17
Conversation
Codecov Report
@@ Coverage Diff @@
## main #17 +/- ##
==========================================
- Coverage 72.50% 72.39% -0.12%
==========================================
Files 26 26
Lines 1953 1945 -8
==========================================
- Hits 1416 1408 -8
Misses 537 537
Continue to review full report at Codecov.
|
@richardreeve I think this is good to go - can you let me know if this resolves your compat errors? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, and the compat stuff is resolved. There are quite a few warnings when I run the tests (which all pass!), which say things like:
"Warning: Assignment to eco
in soft scope is ambiguous because a global variable by the same name exists: eco
will be treated as a new local. Disambiguate by using local eco
to suppress this warning or global eco
to assign to the existing global variable."
It would be nice to resolve this before the release, but that's not an issue for this PR.
Add compat helper, tagbot and some minor edits to
main
branch.