Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows on main #17

Merged
merged 9 commits into from
Apr 9, 2021
Merged

Workflows on main #17

merged 9 commits into from
Apr 9, 2021

Conversation

claireh93
Copy link
Member

@claireh93 claireh93 commented Apr 8, 2021

Add compat helper, tagbot and some minor edits to main branch.

@claireh93 claireh93 changed the title CompatHelper main Workflows on main Apr 8, 2021
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #17 (7783c9d) into main (8067d9b) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   72.50%   72.39%   -0.12%     
==========================================
  Files          26       26              
  Lines        1953     1945       -8     
==========================================
- Hits         1416     1408       -8     
  Misses        537      537              
Impacted Files Coverage Δ
src/Ecosystem.jl 75.62% <0.00%> (-0.48%) ⬇️
src/Habitats.jl 68.78% <0.00%> (-0.31%) ⬇️
src/units.jl 100.00% <0.00%> (ø)
src/EcoSISTEM.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8067d9b...7783c9d. Read the comment docs.

@claireh93
Copy link
Member Author

@richardreeve I think this is good to go - can you let me know if this resolves your compat errors?

@claireh93 claireh93 mentioned this pull request Apr 9, 2021
Copy link
Member

@richardreeve richardreeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and the compat stuff is resolved. There are quite a few warnings when I run the tests (which all pass!), which say things like:

"Warning: Assignment to eco in soft scope is ambiguous because a global variable by the same name exists: eco will be treated as a new local. Disambiguate by using local eco to suppress this warning or global eco to assign to the existing global variable."

It would be nice to resolve this before the release, but that's not an issue for this PR.

@claireh93 claireh93 merged commit 99a6748 into main Apr 9, 2021
@claireh93 claireh93 deleted the claireh93/compat branch April 12, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants