Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows to match Phylo.jl and Diversity.jl #40

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Conversation

richardreeve
Copy link
Member

Update workflows to use shells and match Phylo.jl and Diversity.jl.

@richardreeve
Copy link
Member Author

@claireh93 This is just for symmetry with Phylo and Diversity. I managed to work out how I did the wrong PR (by doing it again). Even if you create a branch from dev, and then go to dev on GitHub and accept the dialogue to create a PR, it still makes it a PR into main unless you change it?!

@richardreeve richardreeve self-assigned this Apr 16, 2021
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

❗ No coverage uploaded for pull request base (dev@6aafff2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev      #40   +/-   ##
======================================
  Coverage       ?   79.42%           
======================================
  Files          ?       45           
  Lines          ?     2794           
  Branches       ?        0           
======================================
  Hits           ?     2219           
  Misses         ?      575           
  Partials       ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aafff2...37b7178. Read the comment docs.

Copy link
Member Author

@richardreeve richardreeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just commenting on why I made the changes!

@@ -14,7 +14,7 @@ jobs:
strategy:
matrix:
julia-version:
- '1.6'
- '1'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to note that this is so CompatHelper runs on whatever the latest formal release of Julia.

uuid = "aa819f21-2bde-4658-8897-bab36330d9b7"
version = "2"
Pkg.add(; name, uuid, version)
shell: julia --color=yes {0}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uses this nice shell format to you can just write Julia code.

@@ -18,15 +18,15 @@ jobs:
- name: Set up julia
uses: julia-actions/setup-julia@v1
with:
version: '1.6'
version: '1'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again so docs run on whatever the latest formal release of Julia.

@claireh93
Copy link
Member

Looks great, thanks for doing that @richardreeve - I wonder if we don't want those changes to go into main first though?

@coveralls
Copy link

coveralls commented Apr 16, 2021

Pull Request Test Coverage Report for Build 761912335

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.643%

Totals Coverage Status
Change from base Build 755665646: 0.0%
Covered Lines: 2236
Relevant Lines: 3459

💛 - Coveralls

@richardreeve
Copy link
Member Author

Can you just cherry pick the commit?

@claireh93 claireh93 merged commit b2e24d8 into dev Apr 19, 2021
@claireh93 claireh93 deleted the rr/workflows branch April 19, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants