-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update workflows to match Phylo.jl and Diversity.jl #40
Conversation
@claireh93 This is just for symmetry with Phylo and Diversity. I managed to work out how I did the wrong PR (by doing it again). Even if you create a branch from |
Codecov Report
@@ Coverage Diff @@
## dev #40 +/- ##
======================================
Coverage ? 79.42%
======================================
Files ? 45
Lines ? 2794
Branches ? 0
======================================
Hits ? 2219
Misses ? 575
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just commenting on why I made the changes!
@@ -14,7 +14,7 @@ jobs: | |||
strategy: | |||
matrix: | |||
julia-version: | |||
- '1.6' | |||
- '1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to note that this is so CompatHelper runs on whatever the latest formal release of Julia.
uuid = "aa819f21-2bde-4658-8897-bab36330d9b7" | ||
version = "2" | ||
Pkg.add(; name, uuid, version) | ||
shell: julia --color=yes {0} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uses this nice shell format to you can just write Julia code.
@@ -18,15 +18,15 @@ jobs: | |||
- name: Set up julia | |||
uses: julia-actions/setup-julia@v1 | |||
with: | |||
version: '1.6' | |||
version: '1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again so docs run on whatever the latest formal release of Julia.
Looks great, thanks for doing that @richardreeve - I wonder if we don't want those changes to go into main first though? |
Pull Request Test Coverage Report for Build 761912335Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Can you just cherry pick the commit? |
Update workflows to use shells and match Phylo.jl and Diversity.jl.