New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPI testing #66
MPI testing #66
Conversation
Codecov Report
@@ Coverage Diff @@
## main #66 +/- ##
==========================================
+ Coverage 72.47% 72.66% +0.19%
==========================================
Files 26 26
Lines 1951 1961 +10
==========================================
+ Hits 1414 1425 +11
+ Misses 537 536 -1
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 1051907321
💛 - Coveralls |
@richardreeve I think this is ready for you to have a look at now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks okay, and maybe we can ignore the code coverage / testing problem for now, but if you can see a way of fixing it, that would be great...
Co-authored-by: Richard Reeve <git@richardreeve.net>
Co-authored-by: Richard Reeve <git@richardreeve.net>
… into claireh93/mpi
@claireh93 I see your problem here. I hadn't realised this never worked before. For the time being your code works, so let's stick with it and remove the allocation later. It's not easy at all to see how to fix this. I think fundamentally we may need something like a view into an array - possibly in the root process - or distributed calculation of the diversities and abundances... So, assuming this works I think we should just merge it as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now.
PS Another issue I noticed is that (as I'm sure you've noticed) JLD is broken and generates warnings - we need to move away from it I guess. I don't know if the solution is to use the data pipeline or to switch to JLD2, but I'll create an issue about that too. EDIT: now done - #71 |
Further testing to MPI to check answers are the same under different numbers of processes.
Add
gather_abundance()
to pull all abundances to the root node in the correct order.