Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitions updates #68

Merged
merged 11 commits into from Jul 27, 2021
Merged

Transitions updates #68

merged 11 commits into from Jul 27, 2021

Conversation

claireh93
Copy link
Member

A few minor updates to the transitions framework.

@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #68 (2db3f54) into dev (067a0c5) will decrease coverage by 0.13%.
The diff coverage is 80.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #68      +/-   ##
==========================================
- Coverage   80.04%   79.91%   -0.14%     
==========================================
  Files          44       44              
  Lines        2691     2703      +12     
==========================================
+ Hits         2154     2160       +6     
- Misses        537      543       +6     
Impacted Files Coverage Δ
src/Transitions/BiodiversityTransitions.jl 75.00% <60.00%> (-25.00%) ⬇️
src/Transitions/Run.jl 85.00% <80.00%> (ø)
src/Transitions/BiodiversityRun.jl 100.00% <100.00%> (ø)
src/Transitions/Transitions.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 067a0c5...2db3f54. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 30, 2021

Pull Request Test Coverage Report for Build 1058981716

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 29 of 36 (80.56%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 64.648%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Transitions/Run.jl 4 5 80.0%
src/Transitions/BiodiversityTransitions.jl 9 15 60.0%
Totals Coverage Status
Change from base Build 829406986: -0.04%
Covered Lines: 2178
Relevant Lines: 3369

💛 - Coveralls

Copy link
Member

@richardreeve richardreeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor tweaks?

src/Transitions/BiodiversityRun.jl Outdated Show resolved Hide resolved
src/Transitions/BiodiversityRun.jl Outdated Show resolved Hide resolved
src/Transitions/BiodiversityRun.jl Outdated Show resolved Hide resolved
src/Transitions/BiodiversityRun.jl Outdated Show resolved Hide resolved
claireh93 and others added 4 commits July 23, 2021 09:06
Co-authored-by: Richard Reeve <git@richardreeve.net>
Co-authored-by: Richard Reeve <git@richardreeve.net>
Co-authored-by: Richard Reeve <git@richardreeve.net>
Co-authored-by: Richard Reeve <git@richardreeve.net>
@claireh93
Copy link
Member Author

Great, thanks @richardreeve! I'll wait for the tests to pass and then merge in if we are happy

@claireh93 claireh93 merged commit 8d8f3d9 into dev Jul 27, 2021
@claireh93 claireh93 deleted the claireh93/transitions-fixes branch July 27, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants