Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security issues need addressing, perhaps automatically? #22

Closed
lirantal opened this issue Apr 23, 2019 · 5 comments
Closed

Security issues need addressing, perhaps automatically? #22

lirantal opened this issue Apr 23, 2019 · 5 comments

Comments

@lirantal
Copy link
Contributor

What happened:

Because I originally connected Snyk to my GitHub fork of the mockit repository I am now getting automatic fix PRs from Snyk to resolve security issues - while it's nice, it serves little purpose on my own fork :)

Problem description:

Security vulnerabilities affecting mockit need to be addressed.
See the PR here: lirantal#1

Suggested solution:

Perhaps connect to Snyk with your GitHub account and this monitor this repository so it is able to automatically open fix PRs to mitigate security issues.

See example PR in my fork:

image

@boyney123
Copy link
Owner

Hey @lirantal

Awesome stuff, I will get this added. I have set up the account and just saw a button saying raise PR for fix.

How do you set it up for automatic PR's?

@boyney123
Copy link
Owner

image

I have this setup, so hopefully, the will raise in the future?

@lirantal
Copy link
Contributor Author

Yep, looking good!
First PR you need to raise manually then those toggles you checked in will make sure in the future PRs will get open automatically 👌

@boyney123
Copy link
Owner

#24

Happy days!

All set up and should be automatic now, which is really neat. Thanks for the heads up @lirantal and the suggestion

@lirantal
Copy link
Contributor Author

Cool stuff! Congrats 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants