Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert files no extension #20

Closed
wesyq opened this issue Oct 13, 2016 · 10 comments
Closed

Convert files no extension #20

wesyq opened this issue Oct 13, 2016 · 10 comments
Labels

Comments

@wesyq
Copy link

wesyq commented Oct 13, 2016

Hi,

Is there a way to convert files without an extension? For example, I tried this:

java -jar git-lfs-migrate.jar \ -s source.git \ -d dest.git \ -g https://example/lfs-test.git
\ “.clean” \ “.log” \ “SAMPLEDATA”

But the file SAMPLEDATA did not get converted to LFS. Is there a way to accomplish this?

Thanks.

@bozaro
Copy link
Owner

bozaro commented Oct 13, 2016

You command looks like really strange (it has strange quotes and slashes).
Looks like it shold be like:

java -jar git-lfs-migrate.jar -s source.git -d dest.git -g https://example/lfs-test.git .clean "*.log" SAMPLEDATA

git-lfs-migrate takes file masks, not extensions.
So, for example:

  • SAMPLEDATA - files with exact "SAMPLEDATA" name
  • *.log - files ends with ".log"
  • .foo* - files begins with ".foo"

Quotes need on Unix for escape asterisk and question characters. On Windows you can write command without it.

@wesyq
Copy link
Author

wesyq commented Oct 17, 2016

I tried it without the quotes and slashes too, but the files without extensions don't seem to be filtered. This feature to filter extension-less files would be really cool if possible :) If you have already tested it, then may be it is a matter of my environment. I am using Windows. Although I can try it on Mac too.

Btw, thanks for such a great tool, it has really helped me and my migration team :)

@bozaro bozaro closed this as completed in e121fc8 Oct 18, 2016
@bozaro
Copy link
Owner

bozaro commented Oct 18, 2016

Really. Wildcards was processed incorrectly. Fixed.

@bozaro bozaro reopened this Oct 18, 2016
@bozaro
Copy link
Owner

bozaro commented Oct 18, 2016

Not fixed yet :(

@bozaro bozaro closed this as completed in 9b8f47a Oct 18, 2016
@bozaro bozaro reopened this Oct 18, 2016
@bozaro
Copy link
Owner

bozaro commented Oct 18, 2016

I try to fix pattern matching and it works much better.
But unfortunatelly it still not fully correct. I fix this issue something later on this week.

@wesyq
Copy link
Author

wesyq commented Oct 24, 2016

Hi,

Did you get a chance to fix it? :)

@bozaro
Copy link
Owner

bozaro commented Oct 25, 2016

If you use only name patterns and don't use path patterns (like "foo/*.zip"), you can safety use version from master branch.
Correct fix shoud be some later.

@wesyq
Copy link
Author

wesyq commented Oct 25, 2016

Okay, thanks. I will try it. Although the build is failing, but only due to a test assertion, the code can be tried as you said it should be working fine safely.

@wesyq
Copy link
Author

wesyq commented Oct 27, 2016

I managed to convert extension-less files by building the source from master. Thanks a ton!

@wesyq
Copy link
Author

wesyq commented Oct 27, 2016

Also, I noticed that I no longer need to place the backslashes '' in the newer build, and it worked. In the earlier releases, I had to put the backslashes in the command. But not anymore. This is also an improvement.

@bozaro bozaro added the bug label Oct 30, 2016
@bozaro bozaro closed this as completed in 31edfcd Oct 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants