Split out separate sys package #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you have an lz4 dependency in another linked C library you don't need the full wrapper, just a way to compile and link lz4. This commit splits this part out into a separate sys crate to create this possiblity.
thijsc
commented
Nov 24, 2016
| name = "lz4-sys" | ||
| license = "MIT" | ||
| links = "lz4" | ||
| version = "1.19.173" |
There was a problem hiding this comment.
You could chose to have a version number here that's independent from the sys crate.
|
@bozaro What do you think? |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have an lz4 dependency in another linked C library you don't need the full wrapper, just a way to compile and link lz4. This commit splits this part out into a separate sys crate to create this
possiblity.