Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when the system scrolls the table view automatically #13

Open
CZyMfnIPC opened this issue Jan 12, 2015 · 1 comment
Open

Issue when the system scrolls the table view automatically #13

CZyMfnIPC opened this issue Jan 12, 2015 · 1 comment

Comments

@CZyMfnIPC
Copy link

If the table view is scrolled without user interaction, the pong view will not know the current offset of the table, so it may show up on screen unintentionally.

The case that I ran into: I have cells that expand/collapse when they are tapped. If you tap a cell in the middle of the table, the device will automatically move the cells below, thus having no effect on the position of the Pong view up above. However if you tap the last item in the list, it will move everything above. When collapsing, it will scroll the cells down, which also brings down the pong view.

As soon as I scroll the table manually, it sees the correct offset and removes the pong view.

My fix for this was to include a call to "[self.pongRefreshControl scrollViewDidScroll];" after the cell is collapsed, which allows the pong view to update to the correct offset with the new table position.

Maybe this isn't a full-on bug, because I can't find a solution without a major refactor in the Pong library, but it should probably be included in the ReadMe as a footnote to call scrollViewDidScroll in cases where the table might be scrolled outside of "scrollViewDidScroll"

@boztalay
Copy link
Owner

Thanks for finding this! I hadn't tested it with collapsing and expanding cells. I'll need to take a look at it, but I'll make a note for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants