Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin sphinx_rtd_theme version #228

Merged
merged 1 commit into from Sep 16, 2021
Merged

Pin sphinx_rtd_theme version #228

merged 1 commit into from Sep 16, 2021

Conversation

connortann
Copy link
Collaborator

@connortann connortann commented Sep 16, 2021

Closes #227

From experimentation:

  • Pinning an older version of sphinx-rtd-theme seems to fix the issue
  • Removing the autoclasstoc extension does not fix the issue
  • Changing the theme to "classic" does not seem to fix the issue

@connortann connortann added bug Something isn't working documentation Improvements or additions to documentation labels Sep 16, 2021
@connortann connortann self-assigned this Sep 16, 2021
@connortann connortann added this to In progress in Resqpy development via automation Sep 16, 2021
@andy-beer
Copy link
Contributor

The readthedocs docs version is rendering correctly for me, I guess based on this pin @connortann

@connortann
Copy link
Collaborator Author

connortann commented Sep 16, 2021

Yes seems to work for me too. I might investigate removing the autoclasstoc sphinx extension instead, to help debug the root cause, so I can raise an issue report with the relevant tool.

@connortann
Copy link
Collaborator Author

@andy-beer would you kindly create an account on https://readthedocs.org/ , so I can add you as a maintainer?

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2021

Codecov Report

Merging #228 (ceb7c5d) into master (5a96b98) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head ceb7c5d differs from pull request most recent head 3ca98f6. Consider uploading reports for the commit 3ca98f6 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #228   +/-   ##
=======================================
  Coverage   51.81%   51.81%           
=======================================
  Files          53       53           
  Lines       25298    25298           
=======================================
+ Hits        13107    13108    +1     
+ Misses      12191    12190    -1     
Impacted Files Coverage Δ
resqpy/model.py 66.22% <0.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a96b98...3ca98f6. Read the comment docs.

@andy-beer
Copy link
Contributor

@connortann I have created a readthedocs account where I am andy_beer

@connortann connortann merged commit 9205182 into master Sep 16, 2021
Resqpy development automation moved this from In progress to Done Sep 16, 2021
@connortann connortann deleted the docs branch September 16, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

Docs not building correctly
3 participants