New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in minimum curvature method #9

Closed

JoshRosenstein opened this issue Oct 23, 2020 · 1 comment

Labels

bug

JoshRosenstein commented Oct 23, 2020

Hello, was just poking around and saw within your minimum curvature method , your beta has a small parentheses issue.

welltrajconvert/welltrajconvert/wellbore_trajectory.py

Lines 130 to 134 in f1976dd

    
           beta = np.arccos( 
        
               np.cos(inc_rad - inc_rad_shift - (np.sin(inc_rad_shift) * 
        
                                                 np.sin(inc_rad) * 
        
                                                 (1 - np.cos(azim_rad - azim_rad_shift)) 
        
                                                 )))

beta = np.arccos(
    np.cos(inc_rad - inc_rad_shift)
    - (np.sin(inc_rad_shift) * np.sin(inc_rad) * (1 - np.cos(azim_rad - azim_rad_shift)))
)

Owner

bpamos commented Oct 27, 2020

Nice catch. It has been corrected.

bpamos closed this as completed

bpamos added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment