forked from openshift/origin
-
Notifications
You must be signed in to change notification settings - Fork 1
/
secret_updating_controller.go
294 lines (245 loc) · 8.34 KB
/
secret_updating_controller.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
package servingcert
import (
"fmt"
"time"
"github.com/golang/glog"
kapi "k8s.io/kubernetes/pkg/api"
"k8s.io/kubernetes/pkg/client/cache"
kcoreclient "k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset/typed/core/internalversion"
"k8s.io/kubernetes/pkg/controller"
"k8s.io/kubernetes/pkg/runtime"
utilruntime "k8s.io/kubernetes/pkg/util/runtime"
"k8s.io/kubernetes/pkg/util/sets"
"k8s.io/kubernetes/pkg/util/wait"
"k8s.io/kubernetes/pkg/util/workqueue"
"k8s.io/kubernetes/pkg/watch"
"github.com/openshift/origin/pkg/cmd/server/crypto"
"github.com/openshift/origin/pkg/cmd/server/crypto/extensions"
)
// ServiceServingCertUpdateController is responsible for synchronizing Service objects stored
// in the system with actual running replica sets and pods.
type ServiceServingCertUpdateController struct {
secretClient kcoreclient.SecretsGetter
// Services that need to be checked
queue workqueue.RateLimitingInterface
serviceCache cache.Store
serviceController *cache.Controller
serviceHasSynced informerSynced
secretCache cache.Store
secretController *cache.Controller
secretHasSynced informerSynced
ca *crypto.CA
publicCert string
dnsSuffix string
// minTimeLeftForCert is how much time is remaining for the serving cert before regenerating it.
minTimeLeftForCert time.Duration
// syncHandler does the work. It's factored out for unit testing
syncHandler func(serviceKey string) error
}
// NewServiceServingCertUpdateController creates a new ServiceServingCertUpdateController.
// TODO this should accept a shared informer
func NewServiceServingCertUpdateController(serviceClient kcoreclient.ServicesGetter, secretClient kcoreclient.SecretsGetter, ca *crypto.CA, dnsSuffix string, resyncInterval time.Duration) *ServiceServingCertUpdateController {
sc := &ServiceServingCertUpdateController{
secretClient: secretClient,
queue: workqueue.NewRateLimitingQueue(workqueue.DefaultControllerRateLimiter()),
ca: ca,
dnsSuffix: dnsSuffix,
// TODO base the expiry time on a percentage of the time for the lifespan of the cert
minTimeLeftForCert: 1 * time.Hour,
}
sc.serviceCache, sc.serviceController = cache.NewInformer(
&cache.ListWatch{
ListFunc: func(options kapi.ListOptions) (runtime.Object, error) {
return serviceClient.Services(kapi.NamespaceAll).List(options)
},
WatchFunc: func(options kapi.ListOptions) (watch.Interface, error) {
return serviceClient.Services(kapi.NamespaceAll).Watch(options)
},
},
&kapi.Service{},
resyncInterval,
cache.ResourceEventHandlerFuncs{},
)
sc.serviceHasSynced = sc.serviceController.HasSynced
sc.secretCache, sc.secretController = cache.NewInformer(
&cache.ListWatch{
ListFunc: func(options kapi.ListOptions) (runtime.Object, error) {
return sc.secretClient.Secrets(kapi.NamespaceAll).List(options)
},
WatchFunc: func(options kapi.ListOptions) (watch.Interface, error) {
return sc.secretClient.Secrets(kapi.NamespaceAll).Watch(options)
},
},
&kapi.Secret{},
resyncInterval,
cache.ResourceEventHandlerFuncs{
AddFunc: sc.addSecret,
UpdateFunc: sc.updateSecret,
},
)
sc.secretHasSynced = sc.secretController.HasSynced
sc.syncHandler = sc.syncSecret
return sc
}
// Run begins watching and syncing.
func (sc *ServiceServingCertUpdateController) Run(workers int, stopCh <-chan struct{}) {
defer utilruntime.HandleCrash()
defer glog.Infof("Shutting down service signing cert update controller")
defer sc.queue.ShutDown()
glog.Infof("starting service signing cert update controller")
go sc.serviceController.Run(stopCh)
go sc.secretController.Run(stopCh)
if !waitForCacheSync(stopCh, sc.serviceHasSynced, sc.secretHasSynced) {
return
}
for i := 0; i < workers; i++ {
go wait.Until(sc.runWorker, time.Second, stopCh)
}
<-stopCh
}
// TODO this is all in the kube library after the 1.5 rebase
// informerSynced is a function that can be used to determine if an informer has synced. This is useful for determining if caches have synced.
type informerSynced func() bool
// syncedPollPeriod controls how often you look at the status of your sync funcs
const syncedPollPeriod = 100 * time.Millisecond
func waitForCacheSync(stopCh <-chan struct{}, cacheSyncs ...informerSynced) bool {
err := wait.PollUntil(syncedPollPeriod,
func() (bool, error) {
for _, syncFunc := range cacheSyncs {
if !syncFunc() {
return false, nil
}
}
return true, nil
},
stopCh)
if err != nil {
glog.V(2).Infof("stop requested")
return false
}
glog.V(4).Infof("caches populated")
return true
}
func (sc *ServiceServingCertUpdateController) enqueueSecret(obj interface{}) {
key, err := controller.KeyFunc(obj)
if err != nil {
glog.Errorf("Couldn't get key for object %+v: %v", obj, err)
return
}
sc.queue.Add(key)
}
func (sc *ServiceServingCertUpdateController) addSecret(obj interface{}) {
secret := obj.(*kapi.Secret)
if len(secret.Annotations[ServiceNameAnnotation]) == 0 {
return
}
glog.V(4).Infof("adding %s", secret.Name)
sc.enqueueSecret(secret)
}
func (sc *ServiceServingCertUpdateController) updateSecret(old, cur interface{}) {
secret := cur.(*kapi.Secret)
if len(secret.Annotations[ServiceNameAnnotation]) == 0 {
// if the current doesn't have a service name, check the old
secret = old.(*kapi.Secret)
if len(secret.Annotations[ServiceNameAnnotation]) == 0 {
return
}
}
glog.V(4).Infof("updating %s", secret.Name)
sc.enqueueSecret(secret)
}
func (sc *ServiceServingCertUpdateController) runWorker() {
for sc.processNextWorkItem() {
}
}
// processNextWorkItem deals with one key off the queue. It returns false when it's time to quit.
func (sc *ServiceServingCertUpdateController) processNextWorkItem() bool {
key, quit := sc.queue.Get()
if quit {
return false
}
defer sc.queue.Done(key)
err := sc.syncHandler(key.(string))
if err == nil {
sc.queue.Forget(key)
return true
}
utilruntime.HandleError(fmt.Errorf("%v failed with : %v", key, err))
sc.queue.AddRateLimited(key)
return true
}
// syncSecret will sync the service with the given key.
// This function is not meant to be invoked concurrently with the same key.
func (sc *ServiceServingCertUpdateController) syncSecret(key string) error {
obj, exists, err := sc.secretCache.GetByKey(key)
if err != nil {
glog.V(4).Infof("Unable to retrieve service %v from store: %v", key, err)
return err
}
if !exists {
glog.V(4).Infof("Secret has been deleted %v", key)
return nil
}
regenerate, service := sc.requiresRegeneration(obj.(*kapi.Secret))
if !regenerate {
return nil
}
// make a copy to avoid mutating cache state
t, err := kapi.Scheme.DeepCopy(obj)
if err != nil {
return err
}
secret := t.(*kapi.Secret)
dnsName := service.Name + "." + secret.Namespace + ".svc"
fqDNSName := dnsName + "." + sc.dnsSuffix
certificateLifetime := 365 * 2 // 2 years
servingCert, err := sc.ca.MakeServerCert(
sets.NewString(dnsName, fqDNSName),
certificateLifetime,
extensions.ServiceServerCertificateExtension(service),
)
if err != nil {
return err
}
secret.Annotations[ServingCertExpiryAnnotation] = servingCert.Certs[0].NotAfter.Format(time.RFC3339)
secret.Data[kapi.TLSCertKey], secret.Data[kapi.TLSPrivateKeyKey], err = servingCert.GetPEMBytes()
if err != nil {
return err
}
_, err = sc.secretClient.Secrets(secret.Namespace).Update(secret)
return err
}
func (sc *ServiceServingCertUpdateController) requiresRegeneration(secret *kapi.Secret) (bool, *kapi.Service) {
serviceName := secret.Annotations[ServiceNameAnnotation]
if len(serviceName) == 0 {
return false, nil
}
serviceObj, exists, err := sc.serviceCache.GetByKey(secret.Namespace + "/" + serviceName)
if err != nil {
return false, nil
}
if !exists {
return false, nil
}
service := serviceObj.(*kapi.Service)
if service.Annotations[ServingCertSecretAnnotation] != secret.Name {
return false, nil
}
if secret.Annotations[ServiceUIDAnnotation] != string(service.UID) {
return false, nil
}
// if we don't have the annotation for expiry, just go ahead and regenerate. It's easier than writing a
// secondary logic flow that creates the expiry dates
expiryString, ok := secret.Annotations[ServingCertExpiryAnnotation]
if !ok {
return true, service
}
expiry, err := time.Parse(time.RFC3339, expiryString)
if err != nil {
return true, service
}
if time.Now().Add(sc.minTimeLeftForCert).After(expiry) {
return true, service
}
return false, nil
}