Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all IPs #29

Open
djahandarie opened this issue Mar 16, 2022 · 1 comment
Open

Remove all IPs #29

djahandarie opened this issue Mar 16, 2022 · 1 comment

Comments

@djahandarie
Copy link

I think it'd be a nice API improvement (both ergonomically and efficiency-wise) if you could remove all the IPs in one go, for cases where you want to load in a new set of IPs.

(Alternatively a shutdown method would work as well, but in #25 you seem to argue against that architecture.)

@bparli
Copy link
Owner

bparli commented Mar 20, 2022

Hey @djahandarie I'm open to a remove_all_ipaddrs method if its helpful. Alternatively, I'm wondering if an add_batch_ipaddr and remove_batch_ipaddr (where both take an array of &str) might be more useful?

#25 isn't about a shutdown method per se (at least my reading of it). I'm not against an explicit shutdown if its useful, just didn't think it would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants