Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom params #3

Closed
mvdobrinin opened this issue Nov 25, 2020 · 5 comments
Closed

Support for custom params #3

mvdobrinin opened this issue Nov 25, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@mvdobrinin
Copy link

Would be good to be able to send custom query params on the calls to the auth server. Some servers like PingFederate support the concept of authorization adapters, which should be set by the OAuth client.

@bpedroza
Copy link
Owner

I would be open to this. Feel free to make a PR. If you can't do that, could you please provide an example of how you think this might look? For example - are you looking for an optional argument that can be passed to the authorizeUrl method? Maybe an array of custom parameters?

@bpedroza bpedroza added the enhancement New feature or request label Nov 25, 2020
@bpedroza
Copy link
Owner

Could you please also provide a link to the documentation and any specifications for these authorization adapters? It might be worth while to have a different package for adapters if this is something others will need to use with different services.

@mvdobrinin
Copy link
Author

Here is what other clients are doing in this regard - just letting user configure whatever they want.

For PingFederate sometimes you need to add the following query param to the authorize endpoint call.

&pfidpadapterid=OAuthAdapterCCDS

This is just an example of course, and there are different adapters that can be used.

@mvdobrinin
Copy link
Author

@bpedroza
Copy link
Owner

Thanks. I probably won't get to this over the holiday, but I will work on it soon.

@bpedroza bpedroza self-assigned this Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants