Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Universe Entries & Issue Tags #173

Closed
themadman0980 opened this issue Aug 28, 2023 · 5 comments · Fixed by #206
Closed

Feature Request: Universe Entries & Issue Tags #173

themadman0980 opened this issue Aug 28, 2023 · 5 comments · Fixed by #206
Assignees
Labels
enhancement New feature or request

Comments

@themadman0980
Copy link

themadman0980 commented Aug 28, 2023

Is your feature request related to a problem? Please describe.
There are many different universes within comics from Marvel, DC and other publishers. It would be extremely helpful to classify the universe within which an issue occurs for filtering and organisation purposes, and to help with finding similar reading content.

Describe the solution you'd like
A new tag for issues titled "Universe", with a validated list of possible inputs from a centralised list of universes, each with a page describing the universe and its history. The process to add a universe to an issue would include creating a new Universe entry, and then going to an issue and selecting that Universe from the available list (as this grows, a search tool might be necessary).

For example, Marvel has an extensive list of universes, however it makes sense to start with the common ones like Earth-616, the Ultimate Marvel universe, and the Star-Wars universe.

Additional context
As discussed on Matrix.

This could be an optional field, so while it may be more effort to include, it's not necessary to include it for each issue unless somebody wants to go to the effort of updating this metadata.

Each universe would probably need to be linked to one or more publishers, and one or more issues. It seems more logical to link at an issue level rather than a series level, although it would be nice to be able to bulk update this tag for a whole series within the Metron db. It might be wise to allow an issue to be a part of more than 1 universe (if there's some transition mid-issue).

@bpepple bpepple added the enhancement New feature or request label Aug 28, 2023
@bpepple bpepple self-assigned this Jan 19, 2024
@bpepple
Copy link
Owner

bpepple commented Jan 20, 2024

Done some initial work on this the last day or so. I've created a Universe model that contains the following fields:

  • Publisher (Required): The publisher the universe is associated with. For now this is linked to just one publisher, off the top of my head I can't think of any universes that span multiple publishers. So, if folks have some examples please add a comment.
  • Name (Required): The name of the Universe. For ex. "Kingdom Come" or if it's doesn't have one it should be the designated name.
  • Designation: The Designation for the universe. For ex. "Earth 22"
  • Description: A description of the universe.
  • Image: An image use to show the universe.
  • Attribution: If the description uses text from another source (like Wikipedia) add a link to it.

And I've added a m2m universes field to the following models:

  • Character
  • Team
  • Issue

It might be worth adding a m2m field to the Series model, but I'm not sure how worthwhile that would be, so if someone in the community has opinion add a comment.

Regarding bulk updating, I'm creating a management command to handle updating a series for a universe. For requests, I'm thinking of adding a Discussion Page Topic, where folks can add a series & universe info that needs to updated by the admin.

Here's a screenshot of what a Universe Detail page would look like:
image

I've still got to add tests and update the API for the changes, but the bulk of the work is done.

@themadman0980: Are there any other aspects of this I need to address?

@themadman0980
Copy link
Author

This sounds amazing!

One of the main benefits of universe tags for me is as a filtering mechanism for searches, and as such it would be helpful for series to have access to this. Is it possible to make it a calculated read only field which pulls from all the associated issues in the series?

@bpepple
Copy link
Owner

bpepple commented Jan 21, 2024

One of the main benefits of universe tags for me is as a filtering mechanism for searches, and as such it would be helpful for series to have access to this. Is it possible to make it a calculated read only field which pulls from all the associated issues in the series?

What are you filtering for? Issues? Series?

@themadman0980
Copy link
Author

At present, my main use case would be at a series level. But the data definitely belongs at an issue level given the potential for one off crossovers to a different universe IMO.

@bpepple
Copy link
Owner

bpepple commented Jan 22, 2024

Ok, I've pretty much finished this feature request. I think I just need to finish up the following tasks:

  • Add the designation field parameter to the Universes API.
  • Look at adding a constraint to theUniverse model to prevent duplicate values. Most likely using Publisher, Name, and Designation.
  • Add Marvel's Universes to the data fixture (which currently has DC's Universes). Link to current data fixture: 69f57c2

This should be a non-breaking change to the API, but to play it safe, I'll most likely push this to production after this week's releases (since those are the days the API is hit the hardest), most likely Thursday or Friday.

@bpepple bpepple linked a pull request Jan 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants