Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream our SCP changes to abstract the hash function #1220

Closed
Geod24 opened this issue Sep 20, 2020 · 1 comment
Closed

Upstream our SCP changes to abstract the hash function #1220

Geod24 opened this issue Sep 20, 2020 · 1 comment
Assignees
@AndrejMitrovic
Labels
C. Stellar Consensus Protocol An issue which affects the SCP code Story-Points:8 This takes 5 to 7 days to complete type-refactoring An improvement on existing code without visible functional change
Milestone
2. Validator

Comments

@Geod24
Copy link
Collaborator

Geod24 commented Sep 20, 2020

Currently we have a file to abstract away this (https://github.com/bpfkorea/agora/blob/v0.x.x/source/scpp/src/crypto/Hash.h).
This poses some problem when upgrading and it would be good if we could move those changes upstream.
Upstream will probably want this in SCPDriver as there are precedents, but that's up for discussion.
Assigning @AndrejMitrovic since he made the abstraction.
@Geod24 Geod24 added type-refactoring An improvement on existing code without visible functional change C. Stellar Consensus Protocol An issue which affects the SCP code labels Sep 20, 2020
@Geod24 Geod24 added this to the 2. Validator milestone Sep 20, 2020
@AndrejMitrovic
Copy link
Contributor

I'm gonna file an issue upstream and ask if they would be ok with such a change, and if they have a preference on how to do it.

@AndrejMitrovic AndrejMitrovic added the Story-Points:8 This takes 5 to 7 days to complete label Sep 23, 2020
@Geod24 Geod24 closed this as completed Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrejMitrovic AndrejMitrovic

Labels
C. Stellar Consensus Protocol An issue which affects the SCP code Story-Points:8 This takes 5 to 7 days to complete type-refactoring An improvement on existing code without visible functional change
Projects
None yet
Milestone
2. Validator
Development

No branches or pull requests
2 participants
@Geod24 @AndrejMitrovic