-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help reviewing remaining PRs for 0.9.1 #725
Comments
I volunteer #623 to be included :) |
I can help review some stuff. |
Makes sense, and doesn't look like something risky to have in the next release. I'll add to the list :) |
Should we include #714? On one hand it fixes two issues, on the other hand I'm worried of having it in a release without having it on master for some time first. |
I think it should bake in master a bit. I don't think it's a critical bug. |
I'll add #732 since several users are facing this issue. |
Also adding #762 because it fixes a critical issue with ntop. |
Should we cut release branches instead of doing version-freeze tags on PRs? |
Yes, that would be better. |
I'm writing the changelog for 0.9.1 now. I think maybe #742 should be included as well, otherwise we'll introduce a breaking change in this version (disallow optional positional parameters) just to revert to the old behavior in the next version. |
All PRs merged! |
v0.9.1 was released today, so I'll close this issue. Thank you for everyone who helped with reviews and pull requests! |
We had a lot of changes since 0.9.0 came out, and all issues we have on 0.9.1 milestone have a Pull Request open. I would like to merge these soon so we can release 0.9.1 and start focusing on 0.9.2.
These are the PRs I have in mind so far:
If folks could help reviewing those PRs, that would be awesome.
Also, if there are other PRs folks believe should go in our next release, please comment here so we can decide if it should be included or not. I would like to avoid merging big or impactful changes before we release 0.9.1 (especially #535, #667 and #711) since it would be nice to have those changes in
master
for a few weeks before they make into a release.The text was updated successfully, but these errors were encountered: