feat(vm): add VLAN trunk support
#1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jack Hodgkiss <identity@jackhodgkiss.uk>
jackhodgkiss
commented
Mar 3, 2024
proxmoxtf/resource/vm/vm.go
Outdated
Comment on lines
3087
to
3089
| if err != nil { | ||
| // Error parsing VLAN trunks. | ||
| os.Exit(1) |
There was a problem hiding this comment.
Would appreciate help on how best to handle errors.
I am new to golang.
|
Thanks so much for contribution @jackhodgkiss! I'll take a look today / tomorrow. |
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
bpg
approved these changes
Mar 3, 2024
There was a problem hiding this comment.
Great work, thanks @jackhodgkiss!
I've update the error handling code and also add trunks to the automated acceptance test. The acceptance tests are still somewhat experimental, but i'm planning to use them more, esp. for new functionality.
LGTM! 馃殌
|
@all-contributors please add @jackhodgkiss for code |
|
I've put up a pull request to add @jackhodgkiss! 馃帀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor's Note
I have been using the provider to create a series of Proxmox VMs that require multiple VLANs on a single interface. The approach I have taken is to use trunks to pass through multiple tagged VLANs for which interfaces can be created post deployment such as
eth0.10.Trunks whilst missing from the UI within Proxmox are supported and documented.
I have been using this small change without issue for a couple months.
/docsfor any user-facing features or additions./examplefor any new or updated resources / data sources.make exampleto verify that the change works as expected.Proof of Work
The screenshot below shows a network interface with the trunks property containing
10;20;30as trunked VLANs which can the be utilised within the VM after any OS specific network configuration is applied.Community Note
Closes #0000 | Relates #0000