Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vm): regression: provider always tries to update cpu.affinity even if it is not specified #1182

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

bpg
Copy link
Owner

@bpg bpg commented Apr 4, 2024

Contributor's Note

  • I have added / updated documentation in /docs for any user-facing features or additions.
  • I have added / updated templates in /example for any new or updated resources / data sources.
  • I have updated acceptance tests to verify that the change works as expected.

Proof of Work

The new test fails before the fix:

            
            Error: error updating VM: received an HTTP 500 response - Reason: only root can set 'affinity' config
            
              with proxmox_virtual_environment_vm.test_vm5,
              on terraform_plugin_test.tf line 12, in resource "proxmox_virtual_environment_vm" "test_vm5":
              12: 				resource "proxmox_virtual_environment_vm" "test_vm5" {
            
FAIL
FAIL	github.com/bpg/terraform-provider-proxmox/fwprovider/tests	5.826s
FAIL

and passes after:

ok  	github.com/bpg/terraform-provider-proxmox/fwprovider/tests	6.012s

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1180

…even if it is not specified

Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
@bpg bpg added the autoapprove label Apr 4, 2024
@bpg bpg enabled auto-merge (squash) April 4, 2024 23:48
Copy link

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 LGTM! beep boop

@bpg bpg merged commit 82d435f into main Apr 4, 2024
8 checks passed
@bpg bpg deleted the fix-affinity branch April 4, 2024 23:48
@bpg bpg changed the title fix(vm): regressions: provider always tries to update cpu.affinity even if it is not specified fix(vm): regression: provider always tries to update cpu.affinity even if it is not specified Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant