fix(vm): only set initialization.upgrade attribute when not using custom cloud-init file

[nankeen]

Contributor's Note

• I have added / updated documentation in /docs for any user-facing features or additions.
• I have added / updated acceptance tests in /fwprovider/tests for any new or updated resources / data sources.
• I have ran make example to verify that the change works as expected.

Proof of Work

Ran this with the situation that caused me to report #1252

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1252
Closes #1263

[bpg]

Thanks for the PR @nankeen!

I'm curious tho, why this bug is not triggered by the existing example resource that has custom files defined.

I may need to take a deeper look at this, and try to reproduce the use case to make sure the fix addresses the issue.

EDIT: just realized this is another cloning issue 🤦🏼

[nankeen]

I think it is because the example resource isn't cloning an existing VM.

[bpg]

Not that I'm against this fix by any means, but I have troubles reproducing this issue as described in #1252

I'm getting an OK response to the similar request:

@nankeen could you possible shed some light on p.2 from your scenario:

2. Create a 'proxmox_virtual_environment_vm' resource that is cloud init capable

What exactly was configured in the source VM? Would you mind sharing a redacted template?

Also, what is your Proxmox VE version?

[bpg]

I guess this is PVE 7.x -specific, see another case in #1263

[bpg]

LGTM! 🚀

[bpg]

@all-contributors please add @nankeen for code

[allcontributors]

@bpg

I've put up a pull request to add @nankeen! 🎉